Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for beta #5

Closed
narcolepticinsomniac opened this issue Dec 27, 2018 · 1 comment
Closed

Update for beta #5

narcolepticinsomniac opened this issue Dec 27, 2018 · 1 comment

Comments

@narcolepticinsomniac
Copy link
Collaborator

narcolepticinsomniac commented Dec 27, 2018

I unminified the dark CSS file and loaded in the light. I ignored the tabs since you only change them in the light. Fixed a lot of stuff that broke with the latest update to the layout:

https://pastebin.com/uVxJ5aEw

I get why you use table layouts elsewhere, but I really don't understand it in the popup. Horizontal overflow in the popup drives me nuts, and the only thing you have preventing it is max-width on script names. Even in the default, you're setting the max width arbitrarily short to account for 1 or 2 columns, and it still falls apart with long strings in 3 columns. Not to mention unpredictable translated string length and zoom levels.

You could hook up the popup in a flex layout that'd require like a quarter of the total elements, with no hard widths necessary for creating ellipses dynamically. I don't expect a complete overhaul any time soon, but it'd be great in the meantime if you could remove empty .actionpostd so we could at least use them as parent selectors to allow longer max-widths, like .actionpostd:nth-child(2):last-of-type.

actionpostd

@narcolepticinsomniac
Copy link
Collaborator Author

narcolepticinsomniac commented Dec 28, 2018

@derjanb I see you updated the repo less than 24 hours after I posted this. I suppose it's possible you missed this issue, but any kinda response would be appreciated when you get a chance. Happy Holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant