common-ngx-settings: Settings Service depends on an open subscription to init update settings when updateSettings is called.

[Proantagonist]

updateSettings should be able to correctly update state settings without depending on an open subscription on init.

Example:

    this.settingsService
      .init({
        storage: {
          subKey: 'modals'
        },
        settings: {
          beta_acknowledge: {
            value: false,
            persistent: true
          }
        }
      })
      .pipe(
        filter((settings) => {
          return settings['beta_acknowledge'] === false;
        })
      )
      .subscribe(() => { // The subscription is needed, otherwise when the modal closes and the call to update app settings does not execute correctly, leading to the modal opening again on page refresh
        this.openBetaModal();
      });
  }

this.ms
      .open<boolean>(BetaPromptComponent)
      .pipe(
        filter((acknowledged) => {
          return acknowledged;
        })
      )
      .subscribe(() => {
        this.ss.updateSettings({ // Will not work if the settingsService `init` call is not subscribed to
          beta_acknowledge: true
        });
      });

Commit to replicate: aefb7cf

File: libs\aggiemap\ngx\core\src\lib\pages\map\map.component.ts