Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After closed devtools, padding of parent element remains #4467

Closed
minami-minami opened this issue Nov 6, 2022 · 3 comments · Fixed by #4477
Closed

After closed devtools, padding of parent element remains #4467

minami-minami opened this issue Nov 6, 2022 · 3 comments · Fixed by #4477
Labels

Comments

@minami-minami
Copy link
Contributor

Describe the bug

The padding of the parent element is reset with inline style when devtools is opened.
The inline style remains after closed devtools, so original padding specified with non-inline style of parent element is not applied.

image

Your minimal, reproducible example

https://codesandbox.io/s/async-sky-5ibueo?file=/index.html

Steps to reproduce

  1. Open devtools.
  2. Close devtools.

Expected behavior

No padding remains for resetting and the original padding is applied.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

All

react-query version

4.14.5

TypeScript version

No response

Additional context

No response

@minami-minami
Copy link
Contributor Author

Let me handle it if it should be fixed.

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 6, 2022

I think it's weird that we influence the styles of the parent at all. Not sure why this is needed, but I think it got introduced with

So I'm gonna tag @salamaashoush as well.

Let me handle it if it should be fixed.

if you want to tackle it, please go ahead. Thank you 🙏

@TkDodo TkDodo added bug Something isn't working package: react-query-devtools labels Nov 6, 2022
@salamaashoush
Copy link
Contributor

I am gonna check it this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants