Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear is missing in QueryResult type definition #692

Closed
Regaddi opened this issue Jul 2, 2020 · 1 comment · Fixed by #696
Closed

clear is missing in QueryResult type definition #692

Regaddi opened this issue Jul 2, 2020 · 1 comment · Fixed by #696
Labels
released

Comments

@Regaddi
Copy link

Regaddi commented Jul 2, 2020

Describe the bug
When calling useQuery in a TypeScript project, clear is not defined as a valid key of the returned object.

To Reproduce

  1. Visit https://codesandbox.io/s/youthful-kilby-1ktsq?file=/src/App.tsx
  2. See TypeScript error: Property 'clear' does not exist on type 'QueryResult<unknown, Error>'. ts(2339)

Expected behavior
clear should be part of the type definition for QueryResult.

Additional context
There might be other keys that are currently missing in the type definitions.
@MarceloAlves MarceloAlves mentioned this issue Jul 2, 2020
Merged
@tannerlinsley
Copy link
Collaborator

🎉 This issue has been resolved in version 2.4.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): add clear to QueryResultBase
2 participants
@Regaddi @tannerlinsley