feat: implement vue adapter #3848
Conversation
|
@Mokshit06 is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -2,7 +2,7 @@ | |||
| "private": true, | |||
| "repository": "https://github.com/tanstack/react-table.git", | |||
| "scripts": { | |||
| "linkAll": "lerna exec 'yarn link' && lerna exec 'yarn link @tanstack/react-table' && lerna exec 'yarn link @tanstack/solid-table'", | |||
| "linkAll": "lerna exec 'yarn link' && lerna exec 'yarn link @tanstack/react-table' && lerna exec 'yarn link @tanstack/solid-table' && lerna exec 'yarn link @tanstack/vue-table'", | |||
There was a problem hiding this comment.
These extra links shouldn’t be necessary. Only the core. Right?
There was a problem hiding this comment.
I added them because the @tanstack/react-table existed before I opened the solid-table PR, so I thought that other adapters should also be added, but do we need to really do yarn link with workspaces at all?
There was a problem hiding this comment.
You’re not supposed to have to, but for whatever reason, I found it necessary for the core.
There was a problem hiding this comment.
So should I remove all these packages and add @tanstack/table-core instead? Not sure why react-table was there earlier, since it isn't being used as dependency anywhere
There was a problem hiding this comment.
Yeah, let's do that
This PR implements a vue adapter for react-table v8 alpha. It needs a bit more testing, but from the few examples I tested it with, it seemed to function properly