Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pagination behavior with autoResetPageIndex set to true when deleting rows #4994

Open
2 tasks done
robertjvardy opened this issue Jul 26, 2023 · 1 comment
Open
2 tasks done

Comments

@robertjvardy
Copy link

robertjvardy commented Jul 26, 2023

Describe the bug

Currently working on a table with pagination and a display column that removes the current row.

  • The data for the table is stored in react state and passed into the data prop.
  • The display column performs a removal by filtering the current row out of the state.
    Accordingly, autoResetPageIndex needs to be set to false to prevent the pageIndex state from resetting on every row delete.

Everything works well until all of the rows are deleted on the last page.
The pageIndex state doesnt update, even though the getPageCount response does.
I would assume that even with autoResetPageIndex set to false, the pageIndex state should update when data is deleted and the page count decreases.

Your minimal, reproducible example

will provide on request

Steps to reproduce

Steps To preproduce

  1. Create a table that:
  • uses pagination
  • has a display column to remove the current row
  • has autoResetPageIndex set to false
  • has enough data to populate more than one page
  1. navigate to the last page
  2. remove all of the rows by clicking the delete buttons one by one

Expected behavior

Expected:
When the last row is removed the table state should decrease the pageIndex state to match the page count

Actual:
pageIndex is unchanged and there is no data shown since the pageIndex is out of range relative to the new number of pages

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

issue happens on any OS with any browser

react-table version

8.5.15

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@p-viral
Copy link

p-viral commented Feb 15, 2024

I hope this gets fixed soon. Not sure if others are using this or not, but this is a real blocker for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants