You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently, I made a package upgrade from 8.5.13 to 8.10.7, and now, sorting undefined values doesn't work as usual. My dataset has some values as undefined for some specific requirements, hence I added sortUndefined : 1 as suggested in the docs.
After reviewing again my implementation I decided to try out reverting the lib version, and it worked just fine.
I'm not sure if it is only me, but creating a fork and updating the Sorting example in Codesandbox has been painful, it's been too slow these last few days. I had to lower the length of the dataset to 1000.
To reproduce the issue, my setup looks like this:
Create a dataset with rows containing some number values, for example:
{
accessorKey: 'amount'
header:...
// Just an example...
cell: (props)=>props.getValue()??'-'
sortUndefined: 1}
Sorting by amount in descending will put undefined values on top.
Expected behavior
The expected behavior is: Sorting by amount in descending will put undefined values at the bottom of the table.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
MacOS - Chrome
react-table version
8.10.7
TypeScript version
5.3.2
Additional context
No response
Terms & Code of Conduct
I agree to follow this project's Code of Conduct
I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
The text was updated successfully, but these errors were encountered:
Describe the bug
Recently, I made a package upgrade from
8.5.13
to8.10.7
, and now, sorting undefined values doesn't work as usual. My dataset has some values as undefined for some specific requirements, hence I addedsortUndefined : 1
as suggested in the docs.After reviewing again my implementation I decided to try out reverting the lib version, and it worked just fine.
Your minimal, reproducible example
https://codesandbox.io/p/devbox/hungry-rhodes-kf5f6p
Steps to reproduce
I'm not sure if it is only me, but creating a fork and updating the Sorting example in Codesandbox has been painful, it's been too slow these last few days. I had to lower the length of the dataset to 1000.
To reproduce the issue, my setup looks like this:
Create a dataset with rows containing some number values, for example:
Then, on the column definitions:
Sorting by
amount
in descending will put undefined values on top.Expected behavior
The expected behavior is: Sorting by
amount
in descending will put undefined values at the bottom of the table.How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
MacOS - Chrome
react-table version
8.10.7
TypeScript version
5.3.2
Additional context
No response
Terms & Code of Conduct
The text was updated successfully, but these errors were encountered: