Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowSelection regression in 8.11 #5246

Closed
2 tasks done
akraines opened this issue Dec 31, 2023 · 0 comments · Fixed by #5253
Closed
2 tasks done

RowSelection regression in 8.11 #5246

akraines opened this issue Dec 31, 2023 · 0 comments · Fixed by #5253

Comments

@akraines
Copy link
Contributor

akraines commented Dec 31, 2023

Describe the bug

v8.10.7...v8.11.2#diff-ae44d70a3d740c5497966649de87672ebb255cf384eb2c3b14356f60d3f1da40

packages/table-core/src/features/RowSelection.ts
Line 559: const row = table.getRow(id, true)

table.getRow doesnt support rows with string id's.
I get an error when toggling Select on a grouped row

Your minimal, reproducible example

https://codesandbox.io/p/devbox/kind-leaf-4474wy?file=%2Fsrc%2Fmain.tsx

Steps to reproduce

A table with grouping and row selection

Group by a column
Toggle select on a grouping row [for which RT generates an Id of groupKet:rowId]

Something Went wrong

Expected behavior

It selects the row [and its sub rows if implemented correctly]

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

Windows

react-table version

8.11.*

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant