Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footerClassName is not honored #598

Closed
hansena opened this issue Nov 3, 2017 · 9 comments
Closed

footerClassName is not honored #598

hansena opened this issue Nov 3, 2017 · 9 comments
Labels
critical Issues or bugs that are highly critical and must be solved as soon as possible.

Comments

@hansena
Copy link

hansena commented Nov 3, 2017

What version of React-Table are you using?

6.7.4

What bug are you experiencing, or what feature are you proposing?

footerClassName is not being honored

Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.

https://codesandbox.io/s/r1xnrox1o

What are the steps to reproduce the issue?

  1. create a table with a footer
  2. apply a class using footerClassName
  3. footer renders without class
@gary-menzel gary-menzel added the critical Issues or bugs that are highly critical and must be solved as soon as possible. label Nov 5, 2017
@hansena
Copy link
Author

hansena commented Nov 26, 2017

fixed in #619

@hansena hansena closed this as completed Nov 26, 2017
@gutenye
Copy link

gutenye commented Jan 2, 2018

@gary-menzel @hansena still not work with latest version v6.7.6
Tested in https://codesandbox.io/s/9z8469xlpw

Is the fix released yet?

@gary-menzel
Copy link
Contributor

Yes - but it looks like the fix provided by @hansena was not properly merged into the file.

But there are workarounds....

You'll have to use getTfootTdProps override on the table (and return a className in the object) until it can be looked at again.

You can also override getFooterProps on the column and do the same thing.

There are no automated tests and there are probably too many places where the same thing can be done.

@gary-menzel gary-menzel reopened this Jan 2, 2018
@tannerlinsley
Copy link
Collaborator

Closing due to issue age. If you think this issue needs to be reopened, please check the latest version of React-Table for the issue once more and reopen if appropriate. Thanks!

@CaitlinWeb
Copy link

I encountered this issue with version 6.8.5. Can this be reopened?

@pouretrebelle
Copy link

+1
Still having this issue on 6.8.6

@rndm2
Copy link

rndm2 commented Dec 14, 2018

Me too

@thedustyrover
Copy link

this is still occuring on 6.9.2. Here is a sandbox example, the last name footer is set to text-right which is not set:

https://codesandbox.io/s/y51w2k17x

@pixelwhip
Copy link

This still appears to be an issue in 6.10.3. @gary-menzel's workaround worked for me.

Instead off defining

footerClassName: 'custom-class'

try:

getFooterProps: () => ({
  className: 'custom-class'
}),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Issues or bugs that are highly critical and must be solved as soon as possible.
Projects
None yet
Development

No branches or pull requests

9 participants