Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter header element root has tabindex which messes up tabbing through filter inputs #735

Closed
Fralleee opened this issue Jan 10, 2018 · 1 comment

Comments

@Fralleee
Copy link

What version of React-Table are you using?

Version 6.7.5

What bug are you experiencing, or what feature are you proposing?

If I have multiple column filters and I try tabbing between them there's a gap in each where the header-element gets focus. Header element has tabindex:

<div class="rt-th" role="button" tabindex="0">
  <input type="text" value="" style="width: 100%;">
</div>
@Fralleee
Copy link
Author

Fralleee commented Jan 10, 2018

Pull request: #619 seems to have created this issue
This commit (f74ba3c) added tabindex and role of button to fix linting errors, however these props should not apply to filter headers since it creates extra tabindexes between the inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant