Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Info in non Docker Deployment #156

Closed
vabene1111 opened this issue Aug 21, 2020 · 8 comments
Closed

Version Info in non Docker Deployment #156

vabene1111 opened this issue Aug 21, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@vabene1111
Copy link
Collaborator

Since the version number is only packed in the image at release, deployments not using docker will not contain a version number.

@vabene1111 vabene1111 added the bug Something isn't working label Aug 21, 2020
@smilerz
Copy link
Collaborator

smilerz commented Jan 17, 2022

maybe save version number in the DB and do a migration with each release?

@vabene1111
Copy link
Collaborator Author

would be an option .. but i fear that everything except tags or some kind of automation will lead to me forgetting to change the number. But i am sure that there is some way to automate this, maybe with an automated commit or so.

@sebastian0511
Copy link

...or what is with a file like XML or JSON with the version number and changelog in it.
It would deploy with every update and overwrite the existing. The gui load this file an display it and with this way you see directly the version and changelog in all ways of deployment.
And you have of course the ability to automate this with the automated commit or whatever.

@mfeurer
Copy link

mfeurer commented Feb 6, 2022

Would this entail that the version number is shown on https://app.tandoor.dev or would this be a separate issue (if it does not exist yet, I'd be happy to open it)?

@vabene1111
Copy link
Collaborator Author

it ran on dev for a while but is back on latest now. The system page should also not be visible for non superuser users (which i just fixed) although it does not contain any kind of sensitive data.

@mfeurer
Copy link

mfeurer commented Feb 7, 2022

The system page should also not be visible for non superuser users (which i just fixed) although it does not contain any kind of sensitive data.

Sorry, I don't fully understand your answer. What I would basically like to know is: "as a regular user, can I find out which version is running on https://app.tandoor.dev" and "if not, does this issue add such version information".

@vabene1111
Copy link
Collaborator Author

ok now i understand:

  1. A regular user cannot see any version information at the moment
  2. this issue does not add this information as i dont think this is benefitial to the user. Also the hosted version might run special hotfix branches from time to time so it would not really work anyway as long as this issue is not resolved.

generally speaking the hosted version (currently) always gets the latest release when its released or a few days after that. In the future there might be some kind of more stable branch that will get the latest update lets say 2-3 weeks after the main branch so that its generally more stable. But currently development is to fast/unstable to do this.

@vabene1111
Copy link
Collaborator Author

the next version will include a version iformation page based on commit refs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants