Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meal Plan week view doesn't take up the full page height #1782

Closed
bhdouglass opened this issue May 6, 2022 · 6 comments
Closed

Meal Plan week view doesn't take up the full page height #1782

bhdouglass opened this issue May 6, 2022 · 6 comments

Comments

@bhdouglass
Copy link

Tandoor Version

1.2.3

Setup

Docker / Docker-Compose

Reverse Proxy

Traefik

Other

No response

Bug description

The meal plan week view does not take up the full height like it did before the v1.2.x release (see attached screenshot). This also happens when on a phone.

Screenshot_20220506_161205

I don't have a screenshot from before, but previously it would take up the whole space, down to the buttons.

Side note, Tandoor has been super awesome, thanks!

Relevant logs

No response

@vabene1111
Copy link
Collaborator

hmm @Kaibu is it possible that this is related to an attribute you set for the tandoor theme but not the others ?

@bhdouglass can you test the view with the tandoor theme and tell me if its broken there as well ?

@bhdouglass
Copy link
Author

Looks like the Tandoor theme also has this problem:

Screenshot_20220508_081314

@sutherlandm
Copy link

I noticed the same problem when on Firefox, tried Chrome and it loads as expected. The issue is still there even in a Firefox private window without any plugins loaded. All themes on Chrome work as expected.

Firefox:
firefox

Chrome:
chrome

@bhdouglass
Copy link
Author

Oh yeah, should have mentioned I'm using Firefox.I just tried Chromium and it works as expected.

@Kaibu
Copy link
Collaborator

Kaibu commented May 11, 2022

This was due to Firefox intepreting calc(100% - 5px) different to chrome.
calc(100vh - 5px) works fine in Firefox and Chrome

@bhdouglass
Copy link
Author

Works great in v1.2.5, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants