Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with some imports from chefkoch.de #1787

Closed
FlorianDev opened this issue May 9, 2022 · 11 comments
Closed

Problem with some imports from chefkoch.de #1787

FlorianDev opened this issue May 9, 2022 · 11 comments
Labels
bug Something isn't working
Milestone

Comments

@FlorianDev
Copy link

Tandoor Version

1.2.4

Setup

Docker / Docker-Compose

Reverse Proxy

No reverse proxy

Other

No response

Bug description

Some recipes cannot be imported from chefkoch.de.
The preview looks correct (as if you can import it), but when you click on Import & Restart you get the error message "Failure There was an error creating a resource!".

Examples of a working recipe:
https://www.chefkoch.de/rezepte/286071107217209/Tamagoyaki-japanisches-Omelett.html
Example of a recipe where the error occurs:
https://www.chefkoch.de/rezepte/2537801397537249/Japanische-Nudeln-mit-Pilzen.html

When I look at the request, it looks like a part of the payload is empty.

Relevant logs

No response

@FlorianDev
Copy link
Author

I am currently running the latest develop version but the error still persist
My install:
Current Version: develop
Ref: [3789388]

Can I test something else to make sure that the problem is not on my side?

@vabene1111
Copy link
Collaborator

vabene1111 commented May 11, 2022

oh i am sorry, i did not run the imports trough competently because in my rush to get this release trough i did not read your issue correctly. I will review this hopefully tomorrow :)

@vabene1111 vabene1111 reopened this May 11, 2022
@FlorianDev
Copy link
Author

don't worry about it and take your time. the world won't end when I can't import every recipe for some days ;)
unfortunately I can't assist with this problem. python is not my jam :)

@gloriousDan
Copy link
Contributor

I also thought that I resolved this with my PR but today I tested it and discovered that this is a separate issue. That's why I removed the "fixes" line in my pr

@vabene1111
Copy link
Collaborator

Yea this must be something purely tandoor internal and likely just a small thing, if the preview works All the main psrsing is already done

@FlorianDev
Copy link
Author

i just noticed that the ingredient list is also shown to me under step 1. is this related or is this another problem?

@vabene1111
Copy link
Collaborator

this does not sound like an issue, ingredients are added to step one by default.

@FlorianDev
Copy link
Author

super. thanks for the explanation

@vabene1111 vabene1111 added this to the 1.3.0 milestone May 18, 2022
@vabene1111 vabene1111 added the bug Something isn't working label May 18, 2022
@vabene1111
Copy link
Collaborator

ok fixed it, the issue was related to ingredients with leading spaces before commas, added a test to catch this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants