add NEVER_UNIT automation #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lanner. delete method deletes all records for testing the auto planner.
… no longer deletes all records for testing the auto planner.
vabene1111
reviewed
Apr 25, 2023
cookbook/helper/ingredient_parser.py
Outdated
| ingredient = re.sub(rf"\b({rule[0]}) ({rule[1]})\b", r"\2 \1", ingredient) | ||
|
|
||
| else: | ||
| for rule in Automation.objects.filter(space=self.request.space, type=Automation.TRANSPOSE_WORDS, disabled=False).order_by('order'): |
There was a problem hiding this comment.
this hits the database for every ingredient parsed and might also execute extremly large amounts of regex
There was a problem hiding this comment.
That would only occur if not cached - I can take that out and have it so the rule never runs if the cache doesn't exist. Or do you thoughts on another way to limit it?
| @@ -68,6 +68,17 @@ You can also create them manually by setting the following | |||
| These rules are processed whenever you are importing recipes from websites or other apps | |||
| and when using the simple ingredient input (shopping, recipe editor, ...). | |||
|
|
|||
| ## Transpose Words | |||
There was a problem hiding this comment.
Is there also documentation for never unit ? or is that the same as transpose words?
There was a problem hiding this comment.
they are both there...
Bumps [bleach](https://github.com/mozilla/bleach) from 5.0.1 to 6.0.0. - [Release notes](https://github.com/mozilla/bleach/releases) - [Changelog](https://github.com/mozilla/bleach/blob/main/CHANGES) - [Commits](mozilla/bleach@v5.0.1...v6.0.0) --- updated-dependencies: - dependency-name: bleach dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # vue/src/apps/MealPlanView/MealPlanView.vue
…ways be the current day.
…l plan if it has no keywords. Added debug buttons to help with testing.
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.1.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Expose food description in food form
fixed rating sort order and updated tests
Changed remote auth var-name in env, info in docs and processing in settings
…hown. User-level default added to settings
…dients Added option: Hide step ingredients
|
ok so finally got this merged, thanks for your patience. I think one of the next things we need to do with automations is write some more/proper tests because i am slowly loosing oversight but other than that everything seems to be correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.