Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gunicorn debug log #2470

Merged

Conversation

gloriousDan
Copy link
Contributor

While helping to debug some gunicorn startup issues I realized that the gunicorn log level was not yet configurable. So I modified the .env file and boot.sh script to make the gunicorn loglevel configurable by setting the GUNICORN_LOG_LEVEL variable.

We could maybe also use the DEBUG variable to modify the gunicorn log level as well I'm open to both possibilities.

@vabene1111
Copy link
Collaborator

thanks for the PR, have you tested this with the container?

I think having it as an extra variable makes sense but maybe we place it next to the other debug variables in the .env template?

i really need to wirte a proper docs article about all the environment variables and its considerations ...

@gloriousDan
Copy link
Contributor Author

I tested it and with the default setting it indeed behaves as before. With "debug" additional info is printed by gunicorn. I szill have to test what happens when a invalid value is set and how if the other settings work. I also built the docker image (wirthout node though) under: gloriousdan/recipes-debug

But I'll do some further testing and move the env variable to the section at the start and then get back to you.

@vabene1111
Copy link
Collaborator

Thanks, this sounds tested enough to me :)

@gloriousDan
Copy link
Contributor Author

I now tested it with an invalid value and gunicorn starts just fine with the default logging value. I also moved the env variable to the top of the env file and added some more info about it.

@vabene1111 vabene1111 merged commit 903a4c9 into TandoorRecipes:develop May 23, 2023
3 checks passed
@gloriousDan gloriousDan deleted the enable_gunicorn_debug_log branch May 23, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants