Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For FeatureMatching, the QuadTreeAttention-based LoFTR is slower than the original LoFTR #4

Closed
KaneKun opened this issue Apr 10, 2022 · 1 comment

Comments

@KaneKun
Copy link

KaneKun commented Apr 10, 2022

Hi, I find this paper very inspiring and interesting. Really appreciate the code and paper.

After testing the code on the Feature Matching task, I find it achieves better performance than the original LoFTR. But it runs a bit slower than the original LoFTR. For example, on my machine, for the same input pair of images, it runs ~0.380 s, while the original LoFTR runs ~0.27 s.

I am wondering if this is expected, or is it possibly due to my improper compilation of the QuadTreeAttention, or for some other reasons?

Thanks a lot for your help.

@Tangshitao
Copy link
Owner

That's expected. We don't optimize our cuda codes. You can refer to the appendix of the paper.

@KaneKun KaneKun closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants