Location of ascii arts

[TanmayPatil105]

Currently we are moving the ascii arts to /usr/share/procfetch.
Both manually and brew install does the same.
Can we do something like

• When installed manually, ascii arts will be moved to /usr/share/procfetch
• When installed using brew, ascii arts will be moved to /home/linuxbrew/.linuxbrew/share

We need to make changes to code according

void print_process(string art, string color_name)
{
-    string path = "/usr/share/procfetch/ascii/" + art;
+    string path = "SOME_VARIABLE" + art;
    fstream fptr;

[akshaykhoje]

Yeah! Makes it safer not interfering with the root :)
Also, that's a better approach to keep a non-essential package separate from the essential ones. Need to look into this a bit more though.

[youpong]

Generate the appropriate build system for each of brew and manual install with arguments to the configure script.

For brew:

$ ./configure -C brew

For manually:

$ ./configure

[youpong]

configure script substitute @INSTALL_LIB_DIR@ with actual value.

config.h

#define INSTALL_LIB_DIR @INSTALL_LIB_DIR@

void print_process(string art, string color_name)
{
-    string path = "/usr/share/procfetch/ascii/" + art;
+    string path = INSTALL_LIB_DIR + "/" + art;
    fstream fptr;

[youpong]

ascii/Makefile.in:

DATADIR = @INSTALL_LIB_DIR@

[TanmayPatil105]

Yupp, this is what I meant.
And need to make changes here to:

class Procfetch < Formula
    desc "🎨 A command-line system information utility written in C++"
    homepage "https://tanmaypatil105.github.io/procfetch/"
    url "https://github.com/TanmayPatil105/procfetch/archive/refs/tags/v0.1.2.tar.gz"
    sha256 "7788bcbb666337499ed00088b66948e74aed6cb743030d82eb2dd1a65569d710"
    license "GPL-3.0"
    
    def install
      system "./configure -c brew"
      system "make"
      system "sudo mkdir -p $HOMEBREW_PREFIX/share/procfetch/ascii"
      system "sudo cp ascii/* $HOMEBREW_PREFIX/share/procfetch/ascii/"
      bin.install "src/procfetch"
    end
  
    test do
      system "procfetch -t"
    end
  end

[TanmayPatil105]

Changing configure to something like

if [[ $# != 0 && $1 == "-c" && $2 == "brew" ]];
then
    echo "#define INSTALL_LIB_DIR \"$HOMEBREW_PREFIX/procfetch/ascii\"" >> src/config.h
else
    echo "#define INSTALL_LIB_DIR \"/usr/share/procfetch/ascii\"" >> src/config.h
fi 

Ik here I am checking so many conditions :p

[youpong]

Done on configure script and C++ sources.

• Add -C option to configure #113
• print_process() refers to LIB_DIR #118

Homebrew work remains to be done.

[youpong]

The Homebrew work have done.

• Fix procfetch#124: use --prefix instead of -C homebrew-tap#1

So, All work have finished.