Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and display file format with directive override and config default #3

Closed
Tanoti opened this issue Dec 12, 2019 · 0 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Tanoti
Copy link
Owner

Tanoti commented Dec 12, 2019

While the parser just cares about reading comment blocks, the underlying assumption is that the sls files in a fileset will be YAML. As other formats are supported, it would be good to try and detect these by reading the "#!" at the top of the file and setting a format property on the sls file object. To support this, a default could be supplied as a config argument and an override directive "format" used to tell the parser to explicitly set the property. This property can then be displayed in the doc output and maybe later used for format-specific processing.

@Tanoti Tanoti self-assigned this Dec 12, 2019
@Tanoti Tanoti added the enhancement New feature or request label Dec 12, 2019
@Tanoti Tanoti added this to the Release 0.5.0 milestone Jan 2, 2020
@Tanoti Tanoti closed this as completed in 2141b45 Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant