Avoid request 'stitching' when span-reqs is not specified #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the default 'span-reqs' configuration stitched up to 5 requests together if last-prim-kvs implied it was necessary. This caused confusion because it's not getting all results but it's also not limited to just one page. The limit parameter also then became confusing, because the number of items returned by a request would be somewhere between '5' and '5 x limit'. After this commit the various 'get items' functions will return only one page by default and if subsequent pages are needed then span-reqs must be used. Closes #74
|
This is the kind of minor breaking change that Faraday has typically accepted via break versioning. We'll move from 0.10.x to 0.11.x to do this. |
kipz
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the default 'span-reqs' configuration stitched up to 5 requests together if last-prim-kvs implied it was necessary. This caused confusion because it's not getting all results but it's also not limited to just one page. The limit parameter also then became confusing, because the number of items returned by a request would be somewhere between '5' and '5 x limit'.
After this commit the various 'get items' functions will return only one page by default and if subsequent pages are needed then span-reqs must be used.
Closes #74