Cleanup

[folknor]

No problem here, I am just puzzled by it:

1. start.js runs
2. await getData(ctx)
3. findMatches(queryVal, ctx)
4. if (ctx.resultsList) render(ctx)

In step 2, ctx.feedback is set to data.src, and then in step 3, ctx.feedback is set to ctx.feedback = { query, matches, results }.

In between those, I can not see that ctx.feedback is read anywhere?

Can this line in dataController.js

ctx.feedback = data.store = typeof data.src === "function" ? await data.src(query) : data.src;

be changed to

data.store = typeof data.src === "function" ? await data.src(query) : data.src;

Or what am I not seeing?

[folknor]

Also another question, because I don't know JS that well. Does this code in dataController.js change the value of ctx.query?

  let { input, query, data } = ctx;
  query = query ? query(input.value) : input.value;

Should it be

 const { input, query, data } = ctx;

 if (data.cache && data.store) return;

 const queryVal = query ? query(input.value) : input.value;

I don't code in JS that much so I'm not always sure which values are passed by reference and by value.

I could have googled this before asking, but it was easier to just mention it :-)

[folknor]

There's 3 places in the code where you do let { ... } = ctx instead of const { ... } = ctx.

[folknor]

Obviously start.js would have to change if (ctx.feedback instanceof Error) return; to if (ctx.data.store instanceof Error) return; as well along with comment 1.

[TarekRaafat]

No problem here, I am just puzzled by it:

1. start.js runs
2. await getData(ctx)
3. findMatches(queryVal, ctx)
4. if (ctx.resultsList) render(ctx)

In step 2, ctx.feedback is set to data.src, and then in step 3, ctx.feedback is set to ctx.feedback = { query, matches, results }.

In between those, I can not see that ctx.feedback is read anywhere?

Can this line in dataController.js

ctx.feedback = data.store = typeof data.src === "function" ? await data.src(query) : data.src;

be changed to

data.store = typeof data.src === "function" ? await data.src(query) : data.src;

Or what am I not seeing?

Answering your first question, the ctx.feedback is read through the eventEmitter detail.

Your second question, if we applied the proposed change this means that you won't be able to catch the data fetching errors through the eventEmitter.

[TarekRaafat]

There's 3 places in the code where you do let { ... } = ctx instead of const { ... } = ctx.

Thanks for that, I've updated them all in v10.2.4 👍🏻

[folknor]

Ah I didn't see that :-) Thank you.