Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tarkovtracker swaggerUI invalid url provided with task/objective endpoints #402

Open
0pilatos0 opened this issue Jan 10, 2024 · 2 comments · May be fixed by #404
Open

Tarkovtracker swaggerUI invalid url provided with task/objective endpoints #402

0pilatos0 opened this issue Jan 10, 2024 · 2 comments · May be fixed by #404

Comments

@0pilatos0
Copy link
Contributor

0pilatos0 commented Jan 10, 2024 •
edited

I've encountered an issue with the Tarkovtracker SwaggerUI, specifically regarding the URL generation for POST endpoints related to tasks/objectives. The SwaggerUI erroneously appends /api/v2 to the already complete endpoint URLs. This duplication leads to malformed URLs like https://tarkovtracker.io/api/v2/api/v2/progress/task/123 instead of the correct https://tarkovtracker.io/api/v2/progress/task/123.

This issue seems to stem from the OpenAPI specification, where the paths for task and objective progress updates are prefixed with /api/v2. However, the server list in the specification already includes /api/v2 in the base URL. This duplication in the endpoint path and base URL is causing the malformed requests.

This issue impacts the development processes, as the SwaggerUI-generated URLs do not correspond to the actual API endpoints, resulting in failed requests.

(I would be open to contribute)
@0pilatos0 0pilatos0 linked a pull request Jan 10, 2024 that will close this issue
Open
@DysektAI
Copy link

I have no experienced this yet personally (Have not used the API) but curious.

  • Is this is still an ongoing issue?
  • Is the PR you submitted still valid as a fix to the issue?

Thanks again for submitting this issue and PR! 😄

(Moved to issue discussion)

@0pilatos0
Copy link
Contributor Author

Yes this is still an active issue

as seen the /api/v2/ is mentioned twice
image

which results in
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #402 Update API endpoint paths 0pilatos0/TarkovTracker
2 participants
@DysektAI @0pilatos0