Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-skippable option fields regardless of DefaultIgnoreCondition #160

Merged
merged 2 commits into from Aug 2, 2023

Conversation

Tarmil
Copy link
Owner

@Tarmil Tarmil commented Jun 4, 2023

Fixes #154.

  • Fix SkippableOptionFields = false not working for voption
  • Add overload on WithSkippableOptionFields that ignores DefaultIgnoreCondition

@Tarmil Tarmil marked this pull request as ready for review July 30, 2023 23:05
@Tarmil Tarmil merged commit a584b26 into master Aug 2, 2023
6 checks passed
@Tarmil Tarmil deleted the non-skippable-options branch August 2, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using DefaultIgnoreCondition = WhenWritingNull deserializes missing fields as null
1 participant