Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _autoenv_event, _autoenv_from_dir, _autoenv_to_dir? #11

Closed
blueyed opened this issue Dec 1, 2014 · 4 comments
Closed

Rename _autoenv_event, _autoenv_from_dir, _autoenv_to_dir? #11

blueyed opened this issue Dec 1, 2014 · 4 comments
Assignees
Labels

Comments

@blueyed
Copy link
Collaborator

blueyed commented Dec 1, 2014

Should the vars meant to be used by the .env file get renamed, e.g. without leading _ and/or uppercased?

See https://github.com/Tarrasch/zsh-autoenv/blob/master/autoenv.zsh#L198

@Tarrasch
Copy link
Owner

Tarrasch commented Dec 1, 2014

Yea, I guess the _autoenv suffix should be only for internal stuff. If a variable is meant to be set by the user, I suppose it should be just be suffixed with autoenv. I'm not sure about upper case, do they do upper case anywhere else?

@blueyed
Copy link
Collaborator Author

blueyed commented Dec 2, 2014

Upper case is used for the config vars.
I will remove the underscore prefix then.

@blueyed blueyed assigned blueyed and unassigned Tarrasch Dec 2, 2014
@Tarrasch
Copy link
Owner

Tarrasch commented Dec 2, 2014

Well, I think we should choose whatever is the most common convention.

@blueyed blueyed closed this as completed in 364c0fb Dec 2, 2014
@Tarrasch
Copy link
Owner

Tarrasch commented Dec 2, 2014

Awesome initiative! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants