Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why last row not rendering in Sugiyama Algorithm? #63

Closed
yoloroy opened this issue Feb 10, 2020 · 6 comments
Closed

Why last row not rendering in Sugiyama Algorithm? #63

yoloroy opened this issue Feb 10, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@yoloroy
Copy link

yoloroy commented Feb 10, 2020

`
add.setOnClickListener{
if (clicked_nodes.size == 1) {
graphView.adapter.graph.addEdge(Node(clicked_nodes[0]), Node(nodeCount))
graphView.adapter.notifyInvalidated()

            nodesData.add(0)
            nodeCount++
        } else {
            try {
                graphView.adapter.graph.addEdge(searchNodeByData(0, graphView.adapter.graph.nodes), Node(nodeCount))
            } catch (e: ArrayIndexOutOfBoundsException) {
                graphView.adapter.graph.addEdge(Node(0), Node(nodeCount))
            }
            graphView.adapter.notifyInvalidated()

            nodesData.add(0)
            nodeCount++
        }
    }

`

2020-02-11_00-38-09

@yoloroy
Copy link
Author

yoloroy commented Feb 11, 2020

2020-02-11_21-13-48

@yoloroy yoloroy changed the title What I do wrong with Sugiyama Algorithm? Why last row not rendering in Sugiyama Algorithm? Feb 11, 2020
@DennisBlock
Copy link
Contributor

Thats odd. Could you create a repo with a small executable sample project which shows this issue, so we can look at it?

@yoloroy
Copy link
Author

yoloroy commented Feb 12, 2020

I created new project and copy my code, then problem solves... o_0

2020-02-12_20-47-43

@yoloroy
Copy link
Author

yoloroy commented Feb 12, 2020

Problem solves, in original project I added bottom padding and this breaks last row, hah

@GregorBlock GregorBlock added the bug Something isn't working label Mar 23, 2020
@GregorBlock
Copy link
Contributor

Yes we should include the padding in the view calculation. Thanks for that.

@GregorBlock
Copy link
Contributor

This should be fixed in the new version! Try v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants