Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FluidTank crashes game if it has non-existant fluid #437

Closed
1 task done
jollycar opened this issue Aug 9, 2023 · 2 comments · Fixed by #457
Closed
1 task done

[BUG] FluidTank crashes game if it has non-existant fluid #437

jollycar opened this issue Aug 9, 2023 · 2 comments · Fixed by #457
Labels
P-0-High High priority, crash/breaking. Type-Bug There is a problem.

Comments

@jollycar
Copy link
Contributor

jollycar commented Aug 9, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

If a fluid is removed from the game, a FluidTank in your inventory trying to render the old fluid crashes the game.

Related to #382

https://gist.github.com/jollycar/f72b822957922a1bf285c3714454201c

Expected Behavior

Empty the FluidTank and not to crash the game

Steps To Reproduce

  1. Add an existing fluid to a FluidTank
  2. Pick it up as an item in your inventory
  3. close game
  4. remove the fluid from the game
  5. start game
  6. when trying to open your inventory (e), the game crashes

Environment

- OS: Linux
- Java version: 17
- Minecraft version: 1.20.1
- Version: 52c3ff55146b9d63b0660b8956a0ee064e08ff4a

Anything else?

No response

@jollycar jollycar added Status-Triage A Triage Member should take a look at this Type-Bug There is a problem. labels Aug 9, 2023
@justliliandev
Copy link
Contributor

this is a somewhat similar issue, except that here the check if the fluid isn't present isn't right: link
this should also contain a check if the fluid is empty, do you wanna get on it, or should I?

@justliliandev justliliandev added P-0-High High priority, crash/breaking. and removed Status-Triage A Triage Member should take a look at this labels Aug 9, 2023
@jollycar
Copy link
Contributor Author

jollycar commented Aug 9, 2023

@agnor99 you seem to have an idea how to fix this, go ahead. I haven't done anything for this yet.

@justliliandev justliliandev mentioned this issue Aug 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-0-High High priority, crash/breaking. Type-Bug There is a problem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants