Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square snow pattern on Streams #1030

Closed
ghost opened this issue Nov 6, 2016 · 18 comments
Closed

Square snow pattern on Streams #1030

ghost opened this issue Nov 6, 2016 · 18 comments

Comments

@ghost
Copy link

ghost commented Nov 6, 2016

Affected Mod Versions:
  • Forge version: 1.10.2-12.18.2.2120
  • RTG version: 4.1.1.5
  • GeographiCraft version: 0.7.5
  • Streams / Farseek version: 0.2.1 / 1.1
  • Biomes O' Plenty version: 5.0.0.2091
Issue Description:

I found an apparent square snow pattern on streams in an Ice Mountains biome.

2016-11-06_14 35 37

Seed: -4304547433725488807
XYZ: -708 / 120 / -257

Steps to reproduce the issue:
  1. Install RTG with GeographiCraft and Streams.
  2. Generate a RTG world.
  3. Find a snowy biome with a stream in it.
@whichonespink44
Copy link
Member

whichonespink44 commented Nov 6, 2016

Thanks for the comprehensive report - we'll try to reproduce this in our development environment and see if we can figure out what's going on.

@ghost
Copy link
Author

ghost commented Nov 6, 2016

If it makes any difference (for reproducing with given seed), set B:SeparateLandmasses=false in geographicraft.cfg.

@whichonespink44
Copy link
Member

That will definitely make a difference, thanks.

@Sunconure11
Copy link

Encountered this on 1.7.10 when I had streams before I decided to pull it from my pack. I think it might be an issue with streams itself, rather than RTG.

@srs-bsns
Copy link
Member

srs-bsns commented Nov 7, 2016

It could actually be another mod that is interacting badly with the way Streams generates it's streams, which is during the biome decoration process. There have been issues in the past with mods DENYing decoration events which prevents Streams from finishing what it's doing. (MagiaNaturalis in 1.7.10, See #870). However, the nature of these strips doesn't quite fit that, and it's also strange that they are all 8 blocks wide.

@mankra Can we get a full mod list, please. And is this in a dedicated server environment? If Yes, is there a plugin manager in use? (Bukkit/Thermos, etc..)

@ghost
Copy link
Author

ghost commented Nov 7, 2016

Here's the mod list. It's my private modpack which also runs on a dedicated server where I use MSM. No Bukkit etc.

Edit: I reduced the list to the necessary mods, updated to the latest version and can confirm that the pattern is still generating at given coordinates.

  • Biomes O' Plenty 5.0.0.2093
  • Farseek 1.1
  • GeographiCraft 0.7.6
  • Realistic Terrain Generation 4.1.1.6
  • Streams 0.2.1

@whichonespink44
Copy link
Member

whichonespink44 commented Nov 8, 2016

After looking at those screenshots a bit closer, it reminds me of the issue Streams used to have with the stone bridges that would generate perpendicular to the stream.

@ghost
Copy link
Author

ghost commented Nov 9, 2016

Please note the edit in my modlist post.

@srs-bsns
Copy link
Member

srs-bsns commented Nov 9, 2016

I can't reproduce this world. Are you using modified config settings in GeographiCraft?

2016-11-09_09 17 15

@ghost
Copy link
Author

ghost commented Nov 9, 2016

B:SeparateLandmasses=false in geographicraft.cfg

@srs-bsns
Copy link
Member

srs-bsns commented Nov 9, 2016

@delvr

This is only happening where there are streams, nowhere else.
The strips coincide with chunk borders.
This is likely from a bad iteration in the Streams decorator?

2016-11-09_13 19 02
2016-11-09_13 06 31

@delvr
Copy link

delvr commented Nov 10, 2016

Thanks for letting me know, I'll take a look on my end.

@delvr
Copy link

delvr commented Nov 27, 2016

OK this should be fixed in the new Streams 0.3/Farseek 2.0 version. Please give it a try and let me know of any issues, thanks!

@whichonespink44
Copy link
Member

@delvr Just tested a few snowy seeds with the latest versions of RTG, Streams & Farseek and didn't see this issue at all, so hopefully @mankra can confirm it's working on his side too.

Nice work on the SpongeForge compatibility by the way! 👍

@ghost
Copy link
Author

ghost commented Nov 29, 2016

Fix confirmed. Thanks a lot! :-)

@keybounce
Copy link

Streams 0.3?!? When/where was that released?

@srs-bsns
Copy link
Member

@keybounce
Copy link

keybounce commented Feb 11, 2017

Ahh. OK, is there a 0.3 for 1.7.10? I did not see it
EDIT: Never mind, this is not the Streams thread, this is an RTG thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants