Improve configuration management for multiple servers #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to use multiple JSON config files that will be merged into a single configuration
werewolfboy13
requested changes
Feb 5, 2023
|
|
||
| config.json | ||
| config.*.json | ||
| !config.example.json |
There was a problem hiding this comment.
Why is this excluded?
There was a problem hiding this comment.
config.json and config.*.json exclude customized configurations.
config.example.json is the auto generated configuration example (formerly config.json) and explicitly included because it matches config.*.json.
|
Rather than defining what configs to layer when you run squadjs. I think it would be better to have an include directive (eg |
|
Review stalled moving this over to #320 CLOSING DUE TO LACK OF RESPONSE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to split up your configuration and reuse parts on multiple servers.
This changes the example configuration name as proposed in #275
closes #282, closes #275