Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/95] 설정 뷰 네트워크 설정 #111

Merged
merged 13 commits into from
Jul 15, 2021
Merged

[Feat/95] 설정 뷰 네트워크 설정 #111

merged 13 commits into from
Jul 15, 2021

Conversation

leeinae
Copy link
Member

@leeinae leeinae commented Jul 15, 2021

🌈 PR 요약

연결 완료..
하지만 추가 예외 처리를 해주지 않았어요
왜냐
팝업은 좀 협의 후에 띄우는 게 맞다고 생각했기 떄문에..

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

📸 ScreenShot
✅ PR check list
- commit message가 적절한지 확인해주세요. 
- 마지막으로 Coding Convention을 준수했는지 확인해주세요.
- 적절한 branch로 요청했는지 확인해주세요.
- Assignees, Label을 붙여주세요.
- 가능한 이슈를 Link 해주세요.
- PR이 승인된 경우 해당 브랜치는 삭제해주세요.

Linked Issue

close #95

@leeinae
[chore] settingViewController 컨벤션 수정
e13fd68
@leeinae
Merge branch 'dev' of https://github.com/TeamB-um/B-umiOS into feat/95
ddc733e
@leeinae
[chore] APIConstants url, convention 수정
64899b7
@leeinae
[add] fetchUserInfo 메소드 추가 (#95)
609a3f1
@leeinae
[add] LaunchScreen에서 userInfo 조회 후 UserDefault로 저장 (#95)
9b5f497
@leeinae
[add] userDafaults 값으로 푸시알림, 휴지통 기한 설정
97439c1
@leeinae
[fix] login 후 fetchUserInfo 실행 (#95)
1216aaf
@leeinae
[chore] PeriodPopUpVC convention 수정
25102b6
@leeinae
[fix] 삭제 휴지통 기한 설정 후 데이터 전달 값 변경 (#95)
2776c82
@leeinae
[fix] 기간 설정 팝업 picker 데이터 UserDefaults 값으로 셋팅 (#95)
d35014c
@leeinae
[add] updateUserInfo Service 추가
5541b5f
@leeinae
[chore] 삭제 휴지통 기한 데이터 0-7일로 변경 (#95)
d81d30a
@leeinae
[add] 설정 뷰 푸시알림 네트워크 연결
450018b
@leeinae leeinae added 인애 🌿 feature 새로운 기능 📞 network 네트워크 관련 labels Jul 15, 2021
@leeinae leeinae self-assigned this Jul 15, 2021
@leeinae leeinae added this to In Progress in AppJam via automation Jul 15, 2021
@leeinae leeinae requested review from jins0704 and anyukyung and removed request for jins0704 July 15, 2021 08:27
@jins0704
Copy link
Member

좋아 난

anyukyung
anyukyung approved these changes Jul 15, 2021
View reviewed changes
B-umiOS/B-umiOS/Setting/ViewController/SettingViewController.swift
@@ -57,8 +57,9 @@ class SettingViewController: UIViewController, popupDelegate{
$0.addTarget(self, action: #selector(didTapTrashBinManageButton(_:)), for: .touchUpInside)
}

var pushAlarmSwitch = UISwitch().then {
lazy var pushAlarmSwitch = UISwitch().then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addTarget 해주려고 lazy 키워드로 선언했습니다

@leeinae leeinae merged commit d75ebba into dev Jul 15, 2021
AppJam automation moved this from In Progress to Done Jul 15, 2021
@leeinae leeinae deleted the feat/95 branch July 15, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyukyung anyukyung anyukyung approved these changes

@jins0704 jins0704 Awaiting requested review from jins0704

Assignees

@leeinae leeinae

Labels
인애 🌿 feature 새로운 기능 📞 network 네트워크 관련
Projects
AppJam
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 설정 뷰 네트워크 연결
3 participants
@leeinae @jins0704 @anyukyung