[Feat/186] 사용자 알림 설정 가져와서 반영하기 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeinae
reviewed
Sep 15, 2021
| let deletePeriod = UserDefaults.standard.integer(forKey: UserDefaults.Keys.deletePeriod) | ||
|
|
||
| self.pushAlarmSwitch.isOn = isPush | ||
| self.trashbinPeriodLabel.text = "\(deletePeriod)일" |
There was a problem hiding this comment.
trashbinPeriodLabel <- 이거 안 쓰이는건가여? 진석스가 삭제 했을라나...
|
DispatchQueue.main.async |
leeinae
reviewed
Sep 15, 2021
B-umiOS/Podfile.lock
Outdated
Comment on lines
3
to
10
| - Firebase/Analytics (8.6.0): | ||
| - Firebase/Analytics (8.7.0): | ||
| - Firebase/Core | ||
| - Firebase/Core (8.6.0): | ||
| - Firebase/Core (8.7.0): | ||
| - Firebase/CoreOnly | ||
| - FirebaseAnalytics (~> 8.6.0) | ||
| - Firebase/CoreOnly (8.6.0): | ||
| - FirebaseCore (= 8.6.0) | ||
| - Firebase/Messaging (8.6.0): | ||
| - FirebaseAnalytics (~> 8.7.0) | ||
| - Firebase/CoreOnly (8.7.0): | ||
| - FirebaseCore (= 8.7.0) | ||
| - Firebase/Messaging (8.7.0): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 PR 요약
사용자 알림 설정 가져와서 반영했습니다..!
설정값을 가져온 후 바로 switch.isOn 값을 바꿔주니
UISwitch.isOn must be used from main thread only 라는 에러가 떴습니다.
왜인고 하니
UIKit문서에 가보면,
대부분의 경우, UIKit 클래스는 앱의 main thread에서만 사용해야 합니다.
이는 UIResponder에서 파생되거나 앱의 사용자 인터페이스를 조작하는 것과 관련하여 특히 그렇다고 합니다.
그래서 DispatchQueue.main.async를 끼워넣으니 잘되네용.
그냥 본적만 있었는데 왜쓰는지 알게 되었어요..ㅎ,ㅎ
📌 변경 사항
변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.
📸 ScreenShot
✅ PR check list
Linked Issue
close #186