Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/198] 그래프 레이아웃 관련 오류 수정 #199

Merged
merged 3 commits into from
Oct 24, 2021
Merged

[Feat/198] 그래프 레이아웃 관련 오류 수정 #199

merged 3 commits into from
Oct 24, 2021

Conversation

jins0704
Copy link
Member

🌈 PR 요약

SE와 같은 작은 화면에서 오토레이아웃이 제대로 적용이 안되는 오류가 있었습니다.
이 부분에 대해서 수정하고 기능도 다시 한번 점검했습니다.

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

📸 ScreenShot
✅ PR check list
- commit message가 적절한지 확인해주세요. 
- 마지막으로 Coding Convention을 준수했는지 확인해주세요.
- 적절한 branch로 요청했는지 확인해주세요.
- Assignees, Label을 붙여주세요.
- 가능한 이슈를 Link 해주세요.
- PR이 승인된 경우 해당 브랜치는 삭제해주세요.

#### Linked Issue
close #198

@jins0704 jins0704 added 🚨bug Something isn't working 👀 view make layout 🔧 fix 코드(기능) 수정 labels Oct 22, 2021
@jins0704 jins0704 self-assigned this Oct 22, 2021
@jins0704 jins0704 added this to In Progress in AppJam via automation Oct 22, 2021
leeinae
leeinae requested changes Oct 22, 2021
View reviewed changes
B-umiOS/B-umiOS/Source/Separate/Component/GraphView.swift Outdated
}

// MARK: - Properties

var graphData: [GraphComponent] = []
var componentsView: [GraphComponentView] = []
var p = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 변수가 의미하는 바가 뭔가요? 쓰임이 명확한 이름이면 용도를 파악하기 더 쉬울 것 같습니다!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Percent 계산할때 쓰이는 변수입니다. percent로 바꿀게유

This was linked to issues Oct 22, 2021
[bug] 글쓰기 삭제 이동 관련 버그 #194
Closed
[bug] 그래프 뷰 잘림 문제 #198
Closed
@leeinae leeinae removed a link to an issue Oct 22, 2021
[bug] 글쓰기 삭제 이동 관련 버그 #194
Closed
2 tasks
@leeinae
Copy link
Member

leeinae commented Oct 23, 2021

확인했습니다 👍

@jins0704 jins0704 merged commit ef63749 into dev Oct 24, 2021
AppJam automation moved this from In Progress to Done Oct 24, 2021
@jins0704 jins0704 deleted the feat/198 branch October 24, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeinae leeinae leeinae approved these changes

Assignees

@jins0704 jins0704

Labels
🚨bug Something isn't working 🔧 fix 코드(기능) 수정 👀 view make layout
Projects
AppJam
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] 그래프 뷰 잘림 문제
2 participants
@jins0704 @leeinae