Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/207 ] 분리수거함 추가 시 텍스트 필드 색상 및 높이 화면 비율 수정 #208

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

jins0704
Copy link
Member

🌈 PR 요약

해당 pr에서 작업한 내역을 적어주세요.

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

📸 ScreenShot
✅ PR check list
- commit message가 적절한지 확인해주세요. 
- 마지막으로 Coding Convention을 준수했는지 확인해주세요.
- 적절한 branch로 요청했는지 확인해주세요.
- Assignees, Label을 붙여주세요.
- 가능한 이슈를 Link 해주세요.
- PR이 승인된 경우 해당 브랜치는 삭제해주세요.

Linked Issue

close #207

@jins0704 jins0704 added 🚨bug Something isn't working 🧚🏻‍♂️ style 디자인 관련 진석 labels Nov 22, 2021
@jins0704 jins0704 self-assigned this Nov 22, 2021
@jins0704 jins0704 added this to In Progress in AppJam via automation Nov 22, 2021
@@ -19,7 +19,8 @@ extension SettingSeparateViewController {

addButton.snp.makeConstraints { make in
make.trailing.equalToSuperview().offset(-16 * SizeConstants.screenWidthRatio)
make.width.height.equalTo(36 * SizeConstants.screenWidthRatio)
make.width.equalTo(36 * SizeConstants.screenWidthRatio)
make.height.equalTo(36 * SizeConstants.screenHeightRatio)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width, height가 같은 값인가요? 그런 경우라면 height는 높이 비율로 잡지마시고 그냥 width와 동일하게 가셔도 될 것 같습니다!

 make.width.height.equalTo(36 * SizeConstants.screenWidthRatio)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니면 make.size.equalTo(SIZE) 이러케 가도 될 것 같아요

@leeinae
Copy link
Member

leeinae commented Feb 8, 2022

진석군 이거 왜 아직도 머지 안 한건지.
비움 잊지 말아요
제가 머지할게요 어차피 안 볼 것 같으니까 ..

@leeinae leeinae merged commit e661524 into dev Feb 8, 2022
AppJam automation moved this from In Progress to Done Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
진석 🚨bug Something isn't working 🧚🏻‍♂️ style 디자인 관련
Projects
Development

Successfully merging this pull request may close these issues.

[bug] 분리수거함 추가 시 텍스트 필드 색상
2 participants