Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Fix leading minuses on E1 #12

Closed
siwelwerd opened this issue Jan 25, 2021 · 4 comments
Closed

Fix leading minuses on E1 #12

siwelwerd opened this issue Jan 25, 2021 · 4 comments

Comments

@siwelwerd
Copy link
Collaborator

siwelwerd commented Jan 25, 2021

Looks like the handling of leading minuses in systems is not correct. The solution to part (a) of this one should have a leading minus in the fourth equation, but does not.

Screen Shot 2021-01-25 at 1 52 15 PM

@siwelwerd
Copy link
Collaborator Author

Actually, I am wondering if the issue might be within Checkit, namely this function

https://github.com/StevenClontz/checkit/blob/d9142d024196f889913fe747cc70a5f7a0106dce/scripts/generator.sage#L53

@StevenClontz
Copy link
Collaborator

Yes, this is a CheckIt issue; I need to fix it there, and then this bank will be fixed the next time it's built.

@StevenClontz
Copy link
Collaborator

The public bank is now fixed: https://checkit.clontz.org/#/banks/tbil-la/E1/3

As an aside: seed 3 of E1 and E3 use the same matrix (because they're seeded by the same number, and the matrix is generated before other random elements of each outcome). I'm trying to decide if this is desirable behavior (or should randomness be based e,g, on a seed that's not just the version number, but also a hash of the bank and outcome slugs).

@StevenClontz
Copy link
Collaborator

Also the bug that caused this to happen was completely avoidable and I'm a very silly person for not anticipating it! StevenClontz/checkit@25d7fb6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants