[Feat] 소셜 로그인 토큰 UserDefault에 저장 및 기타 수정 (#203) #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
added
세진✨
devxsby
approved these changes
Jul 27, 2022
| @@ -7,9 +7,14 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
|
|
||
| import Foundation | ||
|
|
||
| @propertyWrapper struct UserDefaultWrapper<T> { |
| @@ -139,6 +138,16 @@ final class HomeController: BaseUploadViewController { | |||
| // checkPostStatus() | |||
| setActionSheet() | |||
| } | |||
|
|
|||
| func checkLogin() { | |||
| if !userManager.hasJwtToken { | |||
There was a problem hiding this comment.
클린코드를 지킵시다..~~
not 구문 사용 지양
devxsby
reviewed
Jul 27, 2022
Comment on lines
135
to
139
| let createCharacterView = CreateCharacterViewController.instantiate() | ||
| createCharacterView.isSignUp = false | ||
| let nav = UINavigationController(rootViewController: createCharacterView) | ||
| nav.modalPresentationStyle = .fullScreen | ||
| present(nav, animated: true) |
There was a problem hiding this comment.
instantiate 야무지게 잘 쓰셨네요 굳
그리고 nav는 뭐죠?? 약어 안쓰기로 했잖아요 ..
| @@ -7,9 +7,14 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| protocol CustomPopUpControllerDelegate: AnyObject { | |||
| func popUpDidDismiss() | |||
Comment on lines
18
to
19
| if newValue == nil { UserDefaults.standard.removeObject(forKey: key) } | ||
| else { UserDefaults.standard.setValue(newValue, forKey: key) } |
There was a problem hiding this comment.
와 귀신 같이 잡네..
인간 린트세요?
| @@ -32,7 +36,10 @@ class CharacterNameViewController: UIViewController { | |||
|
|
|||
| namingCharacterLabel.attributedText = attributedStr | |||
|
|
|||
| self.dismiss(animated: true) | |||
| guard let pvc = self.presentingViewController else { return } | |||
| self.dismiss(animated: true) | ||
| guard let pvc = self.presentingViewController else { return } | ||
| self.dismiss(animated: true) { | ||
| pvc.dismiss(animated: true) |
| @@ -180,6 +180,7 @@ final class HaruHappicDetailController: UIViewController { | |||
|
|
|||
| @objc private func showAlertPopUp() { | |||
| let alartPopUpView = CustomPopUpController() | |||
| alartPopUpView.delegate = self | |||
There was a problem hiding this comment.
setDelegate함수에 빼는거랑 showAlertPopUp함수에 넣는거랑 어떤게 맞을지 궁금함 (그냥 궁금)
There was a problem hiding this comment.
alertPopUpView 가 showAlertPopUp 함수 내부에서 선언되어 있어서 setDelegate에서는 접근이 불가능해요 그래서 여기서 밖에 delegate 지정을 못해줍니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 관련 이슈
💥 구현/변경 사항 및 이유
💥 PR Point
💥 참고 사항