[Feat] 네트워크 오류시 띄우는 얼럿 뷰 추가 및 홈 컨트롤러 levelProgressView 이슈 (#210) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
approved these changes
Jul 28, 2022
| @@ -44,4 +44,15 @@ extension UIViewController { | |||
| endPoint: CGPoint(x: 2.4, y: 0.4)) | |||
| } | |||
|
|
|||
| func makeAlert(title: String, message: String? = nil, | |||
| @@ -14,11 +14,10 @@ class LoadingIndicator { | |||
| guard let window = UIApplication.shared.windows.last else { return } | |||
|
|
|||
| let loadingIndicatorView: UIActivityIndicatorView | |||
| if let existedView = window.subviews.first(where: { $0 is UIActivityIndicatorView } ) as? UIActivityIndicatorView { | |||
| if let existedView = window.subviews.first(where: { $0 is UIActivityIndicatorView }) as? UIActivityIndicatorView { | |||
| @@ -86,7 +86,7 @@ extension AuthViewController { | |||
| LoadingIndicator.hideLoading() | |||
| self.dismiss(animated: true) | |||
| default: | |||
| LoadingIndicator.hideLoading() | |||
There was a problem hiding this comment.
hideLoading() 없애면 로딩 뷰가 계속 보이고 그 위에 Alert가 뜰 거 같은데 괜찮을까요?
lsj8706
reviewed
Jul 28, 2022
| func makeAlert(title: String, message: String? = nil, | ||
| okTitle: String = "확인", okAction: ((UIAlertAction) -> Void)? = nil, | ||
| completion : (() -> Void)? = nil) { | ||
| let generator = UIImpactFeedbackGenerator(style: .medium) |
There was a problem hiding this comment.
여기에 hideLoading()을 넣어주는 것도 괜찮겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 관련 이슈
💥 구현/변경 사항 및 이유
💥 참고 사항