Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Custom Month View 현재 달 수정 (#214) #215

Merged
merged 3 commits into from Aug 1, 2022

Conversation

devxsby
Copy link
Contributor

@devxsby devxsby commented Aug 1, 2022

💥 관련 이슈

💥 구현/변경 사항 및 이유

  • 하루해픽, 해픽레포트에서 사용하는 Custom Month View의 현재 달을 시스템에서 자동으로 받아오도록 수정했습니다.
  • 이외 자잘한 코드 수정

💥 참고 사항

하루해픽 사진 뷰 하루해픽 태그 뷰 해픽레포트 뷰
Simulator Screen Shot - iPhone 13 mini - 2022-08-01 at 14 51 51 Simulator Screen Shot - iPhone 13 mini - 2022-08-01 at 14 49 55 Simulator Screen Shot - iPhone 13 mini - 2022-08-01 at 14 49 48

@devxsby devxsby added 🔨 Refactor 리팩토링 수빈✨ 아무것도 모르는 응애 💡Feature 기능 구현 labels Aug 1, 2022
@devxsby devxsby requested a review from lsj8706 August 1, 2022 05:53
@devxsby devxsby self-assigned this Aug 1, 2022
@devxsby devxsby added this to In progress in happic: via automation Aug 1, 2022
Copy link
Contributor

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~!

@@ -16,11 +16,16 @@ final class CustomMonthView: UIView {

// MARK: - Properties
weak var delegate: CustomMonthViewDelegate?
var currentMonth: Int = Calendar.current.component(.month, from: Date())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -11,7 +11,7 @@ import Then

final class HappicReportController: UIViewController {
// MARK: - Properties
var currentMonth: String = "7" {
var currentMonth: String = String(Calendar.current.component(.month, from: Date())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devxsby devxsby merged commit 44b4157 into TeamHappic:develop Aug 1, 2022
happic: automation moved this from In progress to Done Aug 1, 2022
@devxsby devxsby deleted the chore/#214-현재달수정 branch August 1, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
수빈✨ 아무것도 모르는 응애 💡Feature 기능 구현 🔨 Refactor 리팩토링
Projects
Development

Successfully merging this pull request may close these issues.

[Chore] 현재 달 받아오기 코드 수정
2 participants