Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Forge tags #178

Closed
justKaisa opened this issue Dec 8, 2020 · 3 comments
Closed

Support for Forge tags #178

justKaisa opened this issue Dec 8, 2020 · 3 comments

Comments

@justKaisa
Copy link

Hi, great mod!
I'm writing this as I noticed that Aquaculture fish items have the #minecraft:fishes tag on them, but not #forge:raw_fishes (or #forge:cooked_fishes at that).

Adding the tag #forge:raw_fishes would be super helpful, as it would allow these fish to be used in almost any recipes added by other mods, not only Pam's Harvestcraft, but also Simple Farming, Farmer's Delight, you name it!

The reason why #minecraft:fishes is simply not enough, is because this tag isn't used by recipes almost anywhere, but also because this tag includes both cooked and raw fish (e.g. both cooked and raw cod use this). I suppose this is why Forge mods use #forge:raw_fishes tag, so please, consider this.

Thanks!

@justKaisa
Copy link
Author

I get why it was closed, but I did expect at least a response. Nvm...

@GirafiStudios
Copy link
Collaborator

It was closed automatically in the commit I made to add what you suggested :) Figured that would be answer enough!

@justKaisa
Copy link
Author

Lol, I didn't know! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants