Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui crash on videos which have comments #10973

Closed
6 tasks done
djubre7 opened this issue Apr 14, 2024 · 10 comments
Closed
6 tasks done

Ui crash on videos which have comments #10973

djubre7 opened this issue Apr 14, 2024 · 10 comments
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@djubre7
Copy link

djubre7 commented Apr 14, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

27.0

Steps to reproduce the bug

Load subscribed json, watch video without comments - plays, watch video with comments - ui crash

Expected behavior

Watch video regardless of comments

Actual behavior

No response

Screenshots/Screen recordings

No response

Logs

{"user_action":"ui error","request":"ACRA report","content_language":"en-US","content_country":"US","app_language":"en_US","service":"none","package":"org.schabi.newpipe.nightly","version":"0.26.1","os":"Linux Android 13 - 33","time":"2024-04-14 15:27","exceptions":["java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.extractor.stream.Description.getType()' on a null object reference\n\tat org.schabi.newpipe.util.text.TextLinkifier.fromDescription(TextLinkifier.java:70)\n\tat org.schabi.newpipe.util.text.TextEllipsizer.linkifyContentView(TextEllipsizer.java:166)\n\tat org.schabi.newpipe.util.text.TextEllipsizer.setContent(TextEllipsizer.java:62)\n\tat org.schabi.newpipe.info_list.holder.CommentInfoItemHolder.updateFromItem(CommentInfoItemHolder.java:127)\n\tat org.schabi.newpipe.info_list.InfoListAdapter.onBindViewHolder(InfoListAdapter.java:337)\n\tat androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7747)\n\tat androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7847)\n\tat androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6646)\n\tat androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6917)\n\tat androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6757)\n\tat androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6753)\n\tat androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)\n\tat androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)\n\tat androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)\n\tat androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)\n\tat androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4645)\n\tat androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4348)\n\tat androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4919)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat androidx.viewpager.widget.ViewPager.onLayout(ViewPager.java:1775)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat com.google.android.material.appbar.HeaderScrollingViewBehavior.layoutChild(HeaderScrollingViewBehavior.java:149)\n\tat com.google.android.material.appbar.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:43)\n\tat com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:2381)\n\tat androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)\n\tat android.widget.FrameLayout.onLayout(FrameLayout.java:270)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)\n\tat android.widget.FrameLayout.onLayout(FrameLayout.java:270)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)\n\tat androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)\n\tat com.google.android.material.bottomsheet.BottomSheetBehavior.onLayoutChild(BottomSheetBehavior.java:576)\n\tat androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1263)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)\n\tat android.widget.FrameLayout.onLayout(FrameLayout.java:270)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)\n\tat android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)\n\tat android.widget.LinearLayout.onLayout(LinearLayout.java:1582)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)\n\tat android.widget.FrameLayout.onLayout(FrameLayout.java:270)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)\n\tat android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)\n\tat android.widget.LinearLayout.onLayout(LinearLayout.java:1582)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)\n\tat android.widget.FrameLayout.onLayout(FrameLayout.java:270)\n\tat com.android.internal.policy.DecorView.onLayout(DecorView.java:1427)\n\tat android.view.View.layout(View.java:24969)\n\tat android.view.ViewGroup.layout(ViewGroup.java:6784)\n\tat android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4917)\n\tat android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:4240)\n\tat android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:3116)\n\tat android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:10885)\n\tat android.view.Choreographer$CallbackRecord.run(Choreographer.java:1301)\n\tat android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309)\n\tat android.view.Choreographer.doCallbacks(Choreographer.java:923)\n\tat android.view.Choreographer.doFrame(Choreographer.java:852)\n\tat android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)\n\tat android.os.Handler.handleCallback(Handler.java:942)\n\tat android.os.Handler.dispatchMessage(Handler.java:99)\n\tat android.os.Looper.loopOnce(Looper.java:226)\n\tat android.os.Looper.loop(Looper.java:313)\n\tat android.app.ActivityThread.main(ActivityThread.java:8757)\n\tat java.lang.reflect.Method.invoke(Native Method)\n\tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)\n\tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)\n"],"user_comment":""}

Affected Android/Custom ROM version

No response

Affected device model

Samsung s22 ultra

Additional information

No response

@djubre7 djubre7 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Apr 14, 2024
@mwang99
Copy link

mwang99 commented Apr 16, 2024

Also experiencing this bug.

@opusforlife2
Copy link
Collaborator

Doesn't happen to regular videos?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 18, 2024
@djubre7
Copy link
Author

djubre7 commented Apr 18, 2024

Doesn't happen to regular videos?

No, I just rechecked. Videos without comments load normally, with comments I get UI crash...

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 18, 2024
@opusforlife2
Copy link
Collaborator

I'm talking about non-subscribed videos.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 18, 2024
@djubre7
Copy link
Author

djubre7 commented Apr 18, 2024

Same behavior even with the non-subscribed videos. I did managed to open one video with comments, but as soon as I tried to play it, it crashed. Afterwards I couldn't open it again.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 18, 2024
@opusforlife2
Copy link
Collaborator

Alright. Mind updating the description then?

Also, when you say "without comments", do you mean you turn comments off, or videos that actually have zero comments?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 19, 2024
@Uj947nXmRqV2nRaWshKtHzTvckUUpD

This comment was marked as off-topic.

@ITILLI

This comment was marked as off-topic.

@djubre7
Copy link
Author

djubre7 commented Apr 22, 2024

Alright. Mind updating the description then?

Also, when you say "without comments", do you mean you turn comments off, or videos that actually have zero comments?

Videos that actually have zero comments.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 22, 2024
@djubre7 djubre7 changed the title Ui crash on subscribed videos which have comments Ui crash on videos which have comments Apr 22, 2024
@AudricV
Copy link
Member

AudricV commented Apr 22, 2024

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.

Duplicate of #10888. Please search (better, with different keywords?) for duplicates the next time you want to open an issue. Thank you.

@AudricV AudricV closed this as completed Apr 22, 2024
@AudricV AudricV added template ignored The user didn't follow the template/instructions (or removed them) duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

No branches or pull requests

6 participants