Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember player states like Shuffle, Repeat, etc. #1795

Open
2 of 3 tasks
joelmo opened this issue Oct 7, 2018 · 4 comments
Open
2 of 3 tasks

Remember player states like Shuffle, Repeat, etc. #1795

joelmo opened this issue Oct 7, 2018 · 4 comments
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project player Issues related to any player (main, popup and background)

Comments

@joelmo
Copy link

joelmo commented Oct 7, 2018

I use NewPipe for listening to music and I use shuffle mode alot. Therefore I think it would be nice to remember shuffle mode, maybe this can be set as an option in settings. What do you think?

I usually start a playlist from bookmarks, and from there I have to navigate to the player queue and turn on shuffle mode.

@theScrabi
Copy link
Member

I don't think this needs to be enabled in settigs. We could just make the shuffel toggel persistend.

@agarwalakash06
Copy link
Contributor

I am working on this.
Also I think if we are persisting the shuffle mode, then we should also persist the repeat mode.
What are your views?

@Stypox Stypox added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Aug 28, 2019
@PeterHindes
Copy link
Contributor

That is a viable solution. We might also look at implementing double tap on the background button to shuffle.

@TobiGr TobiGr added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Dec 7, 2019
@Stypox
Copy link
Member

Stypox commented Dec 9, 2019

Adding another gesture to the background button (which aready has two: click and long click) does not seem right, also, Android discourages double-click gestures since they are typical on computers but feel strange on phones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants