Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Select Different Download Path in Download Dialog #2285

Open
magi44ken opened this issue Apr 12, 2019 · 21 comments
Open

Feature Request: Select Different Download Path in Download Dialog #2285

magi44ken opened this issue Apr 12, 2019 · 21 comments
Assignees
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project

Comments

@magi44ken
Copy link

In the Download Dialog, add an option to change the default download path to easily manually save to different folders.

@pacorrop
Copy link

This is configurable in settings?

I could instead add the possibility of editing the default path by hand (i.e, through the keyboard), since I have Android Nougat and the default path (/storage/emulated/0/Movies/NewPipe) is somehow not reachable by any non-root user. However, /sdcard/Movies/NewPipe is. When I try to set it through the default path browser, /sdcard/ is empty (like if it was not allowed to browse into it).

I had to manually edit the org.schabi.newpipe.preferences.xml to enable the downloads again.

@magi44ken
Copy link
Author

Yes you change default path in the settings but I want to be able to do in download dialog. There are times I want to save to different folder beside the default folders in the settings.

@TobiGr TobiGr added feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Apr 13, 2019
@TobiGr
Copy link
Member

TobiGr commented Apr 13, 2019

Sounds like a good idea and should be easy to implement

@sherlockbeard
Copy link
Contributor

sherlockbeard commented Apr 15, 2019

hey can anybody guide on how to make it possible . because it currently get location from newpipesetting .
so , my doubt is should the user type in the name of folder. or is there any other way.

@gkeegan
Copy link
Contributor

gkeegan commented Apr 16, 2019

It would probably be best to open the android file manager to select where to download to. Typing in the path may cause issues if NewPipe ever ends up supporting downloading to SD card.

@sherlockbeard
Copy link
Contributor

i started the file explore but i am not sure how to get result from it. does anyone have any experience with it.

@TobiGr
Copy link
Member

TobiGr commented Apr 16, 2019

Please do not use the Android File picker, but the FilePicker library. You can find its usage here:

Intent i = new Intent(getActivity(), FilePickerActivityHelper.class)

However, @kapodamy has just added a storage access framework and other things related to file handling. So it might be clever to build upon the work in #2149 and check which changes @kapodamy made to the way the filepicker is used.

@sherlockbeard
Copy link
Contributor

Thanx @TobiGr . I did the fix. using FilePickerActivityHelper

@Stypox Stypox added the downloader Issue is related to the downloader label Sep 27, 2019
@MuhammadImran2
Copy link

Hello! I would like to work on this :)

please assign me this issue

@sherlockbeard
Copy link
Contributor

damn flashback of 2019 .....

@MuhammadImran2
Copy link

hahahahah sorry i do no see time ok

@sherlockbeard
Copy link
Contributor

hi @MuhammadImran2 plz free to take this as i can't contribute to it .

@MuhammadImran2
Copy link

ok @sherlockbeard ❤️

@opusforlife2
Copy link
Collaborator

@MuhammadImran2 Please wait for confirmation before working on this. The current codebase is on a feature freeze right now because of an upcoming rewrite. So this may or may not be postponed because of that.

@TobiGr
Copy link
Member

TobiGr commented Sep 19, 2023

This needs to wait until after the rewrite or at least until the download handling was refactored

@MuhammadImran2
Copy link

ok @TobiGr

@opusforlife2
Copy link
Collaborator

@MuhammadImran2 Still, I'm assigning this to you so we can keep track of this for later.

@MuhammadImran2
Copy link

ok

@MuhammadImran2 MuhammadImran2 removed their assignment Sep 20, 2023
@opusforlife2
Copy link
Collaborator

@MuhammadImran2 ?

@MuhammadImran2
Copy link

sorry friend mistakenly click on unAssignees but please assign me thank you

@MuhammadImran2
Copy link

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project
Projects
None yet
Development

No branches or pull requests

8 participants