Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during searching #3106

Closed
Suncatcher opened this issue Feb 17, 2020 · 25 comments
Closed

Crash during searching #3106

Suncatcher opened this issue Feb 17, 2020 · 25 comments
Labels
bug Issue is related to a bug requires extractor change This issue requires a change to the extractor youtube Service, https://www.youtube.com/

Comments

@Suncatcher
Copy link

Suncatcher commented Feb 17, 2020

photo_2020-02-17_09-54-58

Steps to reproduce:

  1. Put search term in Cyrillic "настоящее время" (maybe not only this), and hit enter.

It doesn't happen always, just sometimes, I cannot figure any rule. I observe this bug throughout the last three app versions, I believe.

P.S. The screenshot is from the version 0.18.2 but I experienced it in 0.18.3 as well.

@cool-student
Copy link
Contributor

this happened to me as well recently but as stated above it doesn't happen every time. for me it happened when I was scrolling down, possibly something didn't load quickly enough ?

Exception

  • User Action: searched
  • Request: eminem
  • Content Language: GB
  • Service: YouTube
  • Version: v0.18.3
  • OS: Linux Android 10 - 29
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'org.jsoup.select.Elements org.jsoup.nodes.Element.children()' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.collectItems(YoutubeSearchExtractor.java:114)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getPage(YoutubeSearchExtractor.java:92)
	at org.schabi.newpipe.extractor.search.SearchInfo.getMoreItems(SearchInfo.java:62)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getMoreSearchItems$1(ExtractorHelper.java:90)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$DBE2dF7XqVvkl-TcN5nthmVnvzQ.call(Unknown Source:10)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:919)


@Stypox
Copy link
Member

Stypox commented Feb 19, 2020

Could you get more information about the webpage with the apk provided in #1816? @cool-student @Suncatcher

@Stypox Stypox added bug Issue is related to a bug requires extractor change This issue requires a change to the extractor youtube Service, https://www.youtube.com/ labels Feb 19, 2020
@Suncatcher
Copy link
Author

@Stypox this app-debug.apk is from the 5th of October. Is it still actual? Won't it introduce more bugs?

@Stypox
Copy link
Member

Stypox commented Feb 20, 2020

Mmmh maybe it crashes. I will try to provide a new apk when I have time. Please note that the apk's purpose is just that of crashing with more info, not actually fixing anything

@cool-student
Copy link
Contributor

unfortunately this only happened to me once and I'm having a hard time reproducing it :/

@B0pol
Copy link
Member

B0pol commented Feb 22, 2020

Reproduced it. It didn't amke the app crash though, I had no results and error at the bottom

Exception

  • User Action: searched
  • Request: pewdiepie break
  • Content Language: FR
  • GMT Time: 2020-02-22 18:28
  • Package: org.schabi.newpipe.debug
  • Version: 0.18.3
  • Service: YouTube
  • Operating System: Linux Android 8.1.0 - 27
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'org.jsoup.select.Elements org.jsoup.nodes.Element.children()' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.collectItems(YoutubeSearchExtractor.java:114)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getInitialPage(YoutubeSearchExtractor.java:79)
	at org.schabi.newpipe.extractor.utils.ExtractorHelper.getItemsPageOrLogError(ExtractorHelper.java:20)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:50)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$searchFor$0(ExtractorHelper.java:77)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$BBduYDeZ_vXMQYaemaggmTPtqvA.call(Unknown Source:8)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
	at java.lang.Thread.run(Thread.java:764)


@mehedihasanziku
Copy link

Yes, true, it's happened with data network connection & when low internet connectivity. Though i can't reproduce that issue, i will open issue with log or update here when i will face it again.

@Suncatcher
Copy link
Author

The same happens on 0.18.4. The problem persists

photo_2020-02-25_16-08-10

Exception

  • User Action: searched
  • Request: настоящее время
  • Content Language: GB
  • Service: YouTube
  • Version: 0.18.4
  • OS: Linux xiaomi/onc/onc:9/PKQ1.181021.001/V11.0.2.0.PFLMIXM:user/release-keys 9 - 28
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'org.jsoup.select.Elements org.jsoup.nodes.Element.children()' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.collectItems(YoutubeSearchExtractor.java:114)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getInitialPage(YoutubeSearchExtractor.java:79)
	at org.schabi.newpipe.extractor.utils.ExtractorHelper.getItemsPageOrLogError(ExtractorHelper.java:19)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:50)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$searchFor$0(ExtractorHelper.java:77)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$BBduYDeZ_vXMQYaemaggmTPtqvA.call(Unknown Source:8)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)


@wb9688
Copy link
Contributor

wb9688 commented Feb 25, 2020

@Suncatcher: Does this issue also happen with https://send.firefox.com/download/5b21cf1361768659/#NUmIIvWTZ1Lwr2D3CK6L7w? That's a build of NewPipe that parses YouTube's new website and it shouldn't happen there. That build isn't ready yet, so there are other issues with it, but if this issue doesn't happen there, this issue could be closed.

@Suncatcher
Copy link
Author

@wb9688 Installation fails on Android 9

@B0pol
Copy link
Member

B0pol commented Feb 28, 2020

Well just update to v0.18.5, it uses the new website

@Suncatcher
Copy link
Author

Still had no update notification prompt.
BTW, isn't it correct that my version show Content Lang: GB, even when I search content on Russian and my phone is on English (US) language, not GB?
Phone language shouldn't influence content, no?

@B0pol
Copy link
Member

B0pol commented Feb 28, 2020

From v0.18.4 blog post

@B0pol third contribution immensely improves the app for non-English speaker: The country NewPipe sets you in is now set to the one of your system language - No more UK videos in the Trending section if you are actually a proud Russian. This only applies to new installations, don’t worry if you enjoy your English feed, друг.

For content language: we put the phone language for the same reason.
It should use your language instead of English, but it doesn't work currently, that's why you can see sometimes English titles or descriptions even though they aren't English videos (because it's translated).

@Suncatcher
Copy link
Author

but it doesn't work currently

and when will it work?

@Suncatcher
Copy link
Author

On 0.18.6 version it still exists

photo_2020-03-12_21-14-35

@Suncatcher
Copy link
Author

Surprisingly today NewPipe opened live show, though usually it crashes even on videos added 40 minutes ago.

@Suncatcher
Copy link
Author

Suncatcher commented Apr 18, 2020

I have this bug again on latest version

Exception

Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'com.grack.nanojson.JsonObject com.grack.nanojson.JsonObject.getObject(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getErrorMessage(YoutubeStreamExtractor.java:580)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:80)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:61)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:120)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$5fJcha6Sq5APJBLdG6osaJby-mc.call(Unknown Source:4)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14479)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)


@Stypox
Copy link
Member

Stypox commented Apr 20, 2020

Please use the Incredible Error Report to Markdown Converter before sending bug repots
Edit: I edited your comment by manually fixing the json.
By the way, you don't have to provide a screenshot of the bug report activity, is just contains less information than the bug report ;-)

@B0pol
Copy link
Member

B0pol commented May 17, 2020

No it's not the same issue. As you can see in the crash log the error was NullPointerException, and in the last crash log you've sent, it's StreamExctractException
This bug is known: #3576

@Suncatcher
Copy link
Author

Sorry for confusing, posted in correspondent thread

@opusforlife2
Copy link
Collaborator

@Suncatcher Still there as of 0.19.8?

@Suncatcher
Copy link
Author

Haven't seen it for a while

@opusforlife2
Copy link
Collaborator

Alright, thanks. Comment if you see it again.

@Suncatcher
Copy link
Author

It happens again

Exception

  • User Action: searched
  • Request: нихуя не понял но очень интересно умер
  • Content Language: en
  • Service: YouTube
  • Version: 0.20.0
  • OS: Linux Android 9 - 28
Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not get ytInitialData
	at org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getInitialData(YoutubeParsingHelper.java:203)
	at org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.extractClientVersionAndKey(YoutubeParsingHelper.java:222)
	at org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getKey(YoutubeParsingHelper.java:298)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getNewNextPageFrom(YoutubeSearchExtractor.java:233)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getInitialPage(YoutubeSearchExtractor.java:127)
	at org.schabi.newpipe.extractor.utils.ExtractorHelper.getItemsPageOrLogError(ExtractorHelper.java:19)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:55)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$searchFor$0(ExtractorHelper.java:81)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$BBduYDeZ_vXMQYaemaggmTPtqvA.call(Unknown Source:8)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)
Caused by: org.schabi.newpipe.extractor.utils.Parser$RegexException: failed to find pattern "window\["ytInitialData"\]\s*=\s*(\{.*?\});
	at org.schabi.newpipe.extractor.utils.Parser.matchGroup(Parser.java:72)
	at org.schabi.newpipe.extractor.utils.Parser.matchGroup(Parser.java:61)
	at org.schabi.newpipe.extractor.utils.Parser.matchGroup1(Parser.java:52)
	at org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getInitialData(YoutubeParsingHelper.java:200)
	... 20 more


@opusforlife2
Copy link
Collaborator

@Suncatcher Fixed in 0.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug requires extractor change This issue requires a change to the extractor youtube Service, https://www.youtube.com/
Projects
None yet
Development

No branches or pull requests

7 participants