Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "System default" theme option. #3420

Closed
B0pol opened this issue Apr 12, 2020 · 8 comments · Fixed by #3632
Closed

Add "System default" theme option. #3420

B0pol opened this issue Apr 12, 2020 · 8 comments · Fixed by #3632
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface

Comments

@B0pol
Copy link
Member

B0pol commented Apr 12, 2020

Describe the feature you want

I would like NewPipe theme to follow Android theme

Is your feature request related to a problem? Please describe it

If I change Android theme, it won't change NewPipe theme.

Additional context

How will you/everyone benefit from this feature?

It will need less effort to change theme of my apps (apps without system theme option, including NewPipe).
It would also fix #1535 for people who can set a system-wide theme settings (Correct me if I'm wrong, Android 10+ users, LineageOS 16 (and custom ROMs based on Lineage 16), and other custom ROMs implementing system-wide theme settings).

@B0pol B0pol added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Apr 12, 2020
@wb9688 wb9688 added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Apr 24, 2020
@xmha97
Copy link

xmha97 commented Oct 4, 2020

+1

@opusforlife2
Copy link
Collaborator

@xmha97 To show agreement you give a thumbs up on the top comment, not add another comment.

@gary-host-laptop
Copy link

I am on Android 10 and yes, if you slect dark mode to turn on at X time all apps will switch to dark theme if they support it. It is really annoying to not have this feature.

@julianfairfax
Copy link

I'm just dropping in to say that I would also greatly appreciate this feature being added, as it would improve the integration with the android system, and would thus be a welcome change for me. Thanks for all the work you've put into this wonderful app!

@gary-host-laptop
Copy link

Will this be added or something or why was it closed, @Redirion ?

@Redirion
Copy link
Member

Yes as PR #3632 added this option. It will be part of the next NewPipe version

@opusforlife2
Copy link
Collaborator

@LongJohn-Silver "X closed this in #abcd" means that issue was closed by a linked PR which fixes the bug/implements the feature request.

@gary-host-laptop
Copy link

@opusforlife2 Sorry I am using a third party client which did not show all the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants