Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace menu under arrow button with a dialog #4456

Closed
3 tasks done
avently opened this issue Oct 8, 2020 · 1 comment
Closed
3 tasks done

Replace menu under arrow button with a dialog #4456

avently opened this issue Oct 8, 2020 · 1 comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@avently
Copy link
Contributor

avently commented Oct 8, 2020

Checklist

Describe the feature you want

Right now we have to select arrow down button in order to see second line of buttons like subtitles, aspect ratio, open in browser, etc. This is fine until someone will want to show more buttons inside this line. All the buttons from second line should be replaced with AlertDialog or BottomSheet or Popup menu with enabled icons. I'm not sure which one is the best, needs testing to be sure. Popup menu allows to show submenu for subtitles and aspect ratio which is useful.

By making this change we can leave arrow down button but make it working like a scroller to the description. This will allow to tap on it and to see a description even in fullscreen. Once someone make a swipe-to-go-to-description even this button can be removed.

So the proposed look of the buttons in non-fullscreen:
Close video ------------ quality | speed | setup

In fullscreen:
------------ quality | speed | setup | arrow down

If the setup button will be a three dots icon it should be the last in a row in landscape too.

Is your feature request related to a problem? Please describe it

The problem is there are to many buttons. Some users want to add even more buttons. I don't think this UI element like second line with buttons is a great element in the case of many buttons.

How will you/everyone benefit from this feature?

We can close many issues after this idea is implemented. Also the player will be much faster in case of view relayout because it will lose some buttons.

@avently avently added the feature request Issue is related to a feature in the app label Oct 8, 2020
@opusforlife2 opusforlife2 added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Oct 9, 2020
@Stypox
Copy link
Member

Stypox commented Oct 9, 2020

@avently I'd keep all of the discussion about this in #1317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants