Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Intent interception for all links #7456

Open
3 tasks done
goyalyashpal opened this issue Nov 28, 2021 · 5 comments
Open
3 tasks done

Support Intent interception for all links #7456

goyalyashpal opened this issue Nov 28, 2021 · 5 comments
Labels
feature request Issue is related to a feature in the app

Comments

@goyalyashpal
Copy link
Contributor

Checklist

What feature do you want?

  • Newpipe may OPTIONALLY add separate activity for opening all intent links (think: like browser app)
  • and check the incoming link with the newpipe's "supported links" list
  • if the link matches/is supported by newpipe extractor, then open it as media/whatever
  • otherwise pass it back to android system
  • the whole mechanism being similar to open links with app
  • i cant think of a suitable name for the service, but it can be smth like "Newpipe check links" ?!

Why do you want this feature?

Think of it like "dynamic intents" where the supported intents can be updated dynamically by the app. but this is not supported in android (and shouldnt be either imo).

Additional Context:

  • I recently stumbled upon ability to add instance links in Peertube instances < Content < Settings ( NewPipeExtractor#746 )
  • even after adding link there, it was not supported by newpipe when i clicked such a link from other app
  • .... since there can be so many links supported by newpipe, all those obv cant be added in the newpipe's intent
  • but this restricts the ability to use newpipe to its full potential
  • this proposal will make opening all these kinds of links in newpipe very very easy without causing any significant side effects
@goyalyashpal goyalyashpal added the feature request Issue is related to a feature in the app label Nov 28, 2021
@triallax
Copy link
Contributor

Surely there will be some people who will have privacy concerns with an app having access to every single link they open, even if it's NewPipe.

Also, even if people have NewPipe installed, that does not mean they want e.g. YouTube links to open in NewPipe.

Do you have any solutions to the above problems?

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Nov 28, 2021

yeah, glad u asked it. i had smth in mind, but couldnt figure out with which context to say it.

So, with optional service, i meant that

  1. this will be additional service to the intents parsed in current manner.
  2. and there'd be a toggle in newpipe to disable that, saying smth like Enable Newpipe link service with some description.
  3. so, users will have option to disable this additional service for once and for all

for the fine tuning control per link, i thought that
5. there can be option: support all links, or support links in list only.
6. the list can be proper syntax bounded list (maybe text editable?: 馃).
7. See the Peertube instances list for some starting inspiration.

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Nov 28, 2021

the action flow will be smth like following:

  1. user clicks some link to a media service
  2. they see the android's open with popup
  3. if they want to try opening this media link with newpipe, THEN ONLY they will choose this service (say "newpipe browser")
  4. that link will be compared,
  5. if it matches with the list, then will be opened with newpipe
  6. else will be redirected back to android sys

so, for addressing privacy concerns, there are several steps....

  1. this service can be disabled (as i said in prev comment)
  2. this is not at all intended to be default browser (a warning may be shown in this regard somehow) so,
  3. ..... so, this will read link ONLY when user EXPLICITLY chooses newpipe_browser service (step 3 above)

for addressing per service link choice, step 3, and step 5 above, or previous comment

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Nov 28, 2021

i got a bit verbose, sorry for that. but succinting things take a huuuuuuge chunk of mental efforts (and time) for me. and often leads me to procrastinate. so, couldnt do it atm 馃槄. i thought it'd be better to not put it on hold in effort to chase perfection.

@goyalyashpal goyalyashpal mentioned this issue Dec 2, 2021
3 tasks
@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Dec 7, 2021

  • otherwise pass it back to android system

guess what, newpipe ( 0.21.13 ) already has such a screen. tried clicking this link (from telegram):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

2 participants