Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button in player notification #7771

Open
3 tasks done
ghost opened this issue Feb 1, 2022 · 2 comments
Open
3 tasks done

Download button in player notification #7771

ghost opened this issue Feb 1, 2022 · 2 comments
Labels
feature request Issue is related to a feature in the app player notification Anything to do with the MediaStyle notification

Comments

@ghost
Copy link

ghost commented Feb 1, 2022

Checklist

What feature do you want?

The title already explains it.

Adding a small download button next to other notification actions.

Why do you want this feature?

Not any big issue.

Just a small feature that (I think) could be easy to add, and would be very nice.

@ghost ghost added the feature request Issue is related to a feature in the app label Feb 1, 2022
@triallax triallax added player notification Anything to do with the MediaStyle notification good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Feb 1, 2022
@opusforlife2 opusforlife2 changed the title Download button in notification tab Download button in player notification Feb 1, 2022
@XiangRongLin
Copy link
Collaborator

@mhmdanas I don't find think the issue, as is, is good for first timers

  1. There is some ambiguity on whether to add a sixth button to the notifications or whether to make the download button an option for one of the existing 5
  2. many codeplaces need to be touched: the settings, the notification handler where one has to also figure out how to start the download

@triallax
Copy link
Contributor

triallax commented Feb 1, 2022

@XiangRongLin that's fair, my assessment was mistaken.

@triallax triallax removed the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player notification Anything to do with the MediaStyle notification
Projects
None yet
Development

No branches or pull requests

2 participants