Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words are not available on Weblate. #9134

Closed
6 tasks done
ghost opened this issue Oct 15, 2022 · 20 comments · Fixed by #9272
Closed
6 tasks done

Words are not available on Weblate. #9134

ghost opened this issue Oct 15, 2022 · 20 comments · Fixed by #9272
Assignees
Labels
localisation / translation Everything that has to do with translations or Weblate

Comments

@ghost
Copy link

ghost commented Oct 15, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

The words that indicate when the video was released are in English

Why do you want this feature?

Screenshot_20221016-013416_NewPipe

Additional information

Look at the picture, the release date of the video is in English.

@ghost ghost added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 15, 2022
@killerrook
Copy link

killerrook commented Oct 16, 2022

Which language do you want release date to be in? Probably not translated maybe you can help. To help translate type www.newpipe.net and click on translate then select language you can either create an account even with github or proceed without any account as well translate the text you can use automatic suggestions as well and suggest the change

@killerrook

This comment was marked as resolved.

@killerrook

This comment was marked as resolved.

@TobiGr
Copy link
Member

TobiGr commented Oct 16, 2022

Thank you for translating NewPipe!
The dates and times are generated using prettytime. You can find their translation files here. All translation of these components need to be done in their repository. You can find more information on how to add a new language to prettytime here and here.

@TobiGr
Copy link
Member

TobiGr commented Oct 16, 2022

Thank you. It looks like you took the English translation and renamed the file. That means after your changes, there won't be an English localization. You should fix that in your PR :)
(The PR is ocpsoft/prettytime#240)

@TobiGr
Copy link
Member

TobiGr commented Oct 16, 2022

Add the English file to your branch: https://github.com/ocpsoft/prettytime/blob/master/core/src/main/java/org/ocpsoft/prettytime/i18n/Resources_en.java

And make sure to use the correct file path for the Azerbaijan file. It should be /core/src/main/java/org/ocpsoft/prettytime/i18n/Resources_az.java

@ghost
Copy link
Author

ghost commented Oct 16, 2022

I just created a new file. Is the file correct?
Turkish language was added a long time ago.😁

@AudricV AudricV added localisation / translation Everything that has to do with translations or Weblate and removed feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 16, 2022
@ghost
Copy link
Author

ghost commented Oct 16, 2022

Shall I close this issue?

@TobiGr
Copy link
Member

TobiGr commented Oct 16, 2022

Yes, thanks.

@TobiGr TobiGr closed this as completed Oct 16, 2022
@ghost ghost closed this as completed Oct 16, 2022
@ghost ghost closed this as completed Oct 16, 2022
@ghost ghost closed this as completed Oct 16, 2022
@ghost ghost closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2022
@ghost ghost closed this as completed Oct 17, 2022
@ghost ghost reopened this Oct 27, 2022
@ghost
Copy link
Author

ghost commented Oct 27, 2022

The translation file has been merged, you need to add it

@ghost
Copy link
Author

ghost commented Oct 27, 2022

@TobiGr
Copy link
Member

TobiGr commented Oct 27, 2022

Big thank you to you to all NewPipe contributors who contributed to the localization update of prettytime!
We'll just need to update prettytime, the rest is done by NewPipe automatically. The update is not available on maven yet. I'll update it once the new version is available.

@TobiGr TobiGr mentioned this issue Oct 27, 2022
6 tasks
@ghost

This comment was marked as spam.

@ghost

This comment was marked as spam.

@ghost

This comment was marked as spam.

@killerrook
Copy link

killerrook commented Oct 30, 2022

This will be added once the new update is live

@TobiGr
Copy link
Member

TobiGr commented Oct 31, 2022

PrettyTime has some problems with the latest replease. It's still not completely published on maven central ocpsoft/prettytime#248

@ghost
Copy link
Author

ghost commented Nov 1, 2022

No more problems

@TobiGr
Copy link
Member

TobiGr commented Nov 1, 2022

See #9272

@ghost
Copy link
Author

ghost commented Nov 1, 2022

Thank you very much!🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants