Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using auto-rotation while a video is loading crashes the app consistently. #9277

Open
6 tasks done
syboxez opened this issue Nov 2, 2022 · 9 comments
Open
6 tasks done
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@syboxez
Copy link

syboxez commented Nov 2, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.0

Steps to reproduce the bug

May be related to #8152

To reproduce, queue up two or more videos, then at the end of one video, right before the next one starts playing, use auto-rotate. The beginning orientation does not matter, but portrait to landscape or vice versa.

Expected behavior

I expect roration as normal

Actual behavior

App crashes

Screenshots/Screen recordings

No response

Logs

-------------------------------------
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.Activity.runOnUiThread(java.lang.Runnable)' on a null object reference
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.lambda$handleResult$24(VideoDetailFragment.java:1639)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.$r8$lambda$D3sK6QX7ZcbWy9dq9XyuPqnEH_c(Unknown Source:0)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment$$ExternalSyntheticLambda22.run(Unknown Source:4)
	at java.lang.Thread.run(Thread.java:1012)
-------------------------------------

Affected Android/Custom ROM version

LineageOS 17.1 through 20

Affected device model

OnePlus 6, Pixel 3a, Nexus 6P

Additional information

No response

@syboxez syboxez added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Nov 2, 2022
@SameenAhnaf SameenAhnaf added player Issues related to any player (main, popup and background) queue Issue is related to queueing GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up queue Issue is related to queueing labels Nov 2, 2022
@FinnHuelsbusch
Copy link

I also have problems when rotating my OnePlus Nord while there is more than one video in the queue.
I am happy to provide further information or logs if needed but may need instructions on how to extract the information (non rooted device)

Kind regards,
Finn

@killerrook killerrook mentioned this issue Nov 8, 2022
6 tasks
@somos61
Copy link

somos61 commented Nov 8, 2022

alike as #9329 issue
in my case even no need in queue. Using internal player, just rotate screen while playing video and it fails with error message (like on screenshot in mentioned)

@opusforlife2
Copy link
Collaborator

Check with the latest version.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Nov 9, 2022
@FinnHuelsbusch
Copy link

The bug is also present in 0.24.1. Though I have not tried a build from dev.

@somos61
Copy link

somos61 commented Nov 9, 2022

as for me in my post above it's about v 0.24.1, still there

@opusforlife2 opusforlife2 removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Nov 9, 2022
@seniorm0ment
Copy link

Have encountered this issue for a few months, however it is not only during loading. It is also during playback for me. Sometimes I can rotate fine, othertimes when rotating it just crashes with no error.
Very aggravating.

Latest Newpipe, Pixel 6 Pro GrapheneOS

@FinnHuelsbusch

This comment was marked as off-topic.

@ykuksenko
Copy link

Also seeing crashes on rotation but during playback without any message. Newpipe 0.25.1, pixel 4a, GrapheneOS.

@johnstonesnow
Copy link

Ditto, random crashes whether multiple videos queued or not. Lose entire queue each time. Would love it if it could be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

8 participants