Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr bot that releases the link from where to download Artifacts app #9519

Open
4 tasks done
Angelk90 opened this issue Dec 8, 2022 · 7 comments
Open
4 tasks done

Pr bot that releases the link from where to download Artifacts app #9519

Angelk90 opened this issue Dec 8, 2022 · 7 comments
Labels
meta Related to the project but not strictly to code

Comments

@Angelk90
Copy link
Contributor

Angelk90 commented Dec 8, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my question isn't listed.
  • I have taken the time to fill in all the required details. I understand that the question will be dismissed otherwise.
  • I have read and understood the contribution guidelines.

What is/are your question(s)?

Every time a pr is created and everything is successful an Artifacts ap apk is created.

To test app apk, you need to go to pr, summary, Artifacts, app.

The problem that those using github apps can't see this.

Then it has to login with browser to download apk to test it.

It would be possible to create a bot that allows that at the end of all the commits that are done by the creator of the pr, where the tests done by sonar, leave a comment from the bot with the url link from having to be able to download the apk.

Additional information

No response
@Angelk90 Angelk90 added needs triage Issue is not yet ready for PR authors to take up question Not really an issue, but more of a question about how something works labels Dec 8, 2022
@SameenAhnaf SameenAhnaf added meta Related to the project but not strictly to code and removed question Not really an issue, but more of a question about how something works needs triage Issue is not yet ready for PR authors to take up labels Dec 8, 2022
@opusforlife2
Copy link
Collaborator

https://github.com/TeamNewPipe/NewPipe/suites/9766307560/artifacts/469241507

Could you check if your app can download and install the APK from this URL?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Dec 9, 2022
@SameenAhnaf
Copy link
Collaborator

@opusforlife2 Yes, I can.

@opusforlife2
Copy link
Collaborator

Which app? And which app is @Angelk90 using?

@Angelk90
Copy link
Contributor Author

@opusforlife2 : A browser page opens, where it says it doesn't exist. Then having logged in then allows you to download the apk file. App I use is Github for android you can find it on playstore.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Dec 10, 2022
@opusforlife2
Copy link
Collaborator

A browser page opens, where it says it doesn't exist.

This despite being logged in to the app?

@Angelk90
Copy link
Contributor Author

Angelk90 commented Dec 11, 2022 •
edited by github-actions bot

@opusforlife2 :
Screenshot_20221211-014042~2.png

@opusforlife2
Copy link
Collaborator

Ah. Webview. No wonder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Angelk90 @opusforlife2 @SameenAhnaf