Check availability of Samsung DeX only on Samsung devices #9619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirion
force-pushed
the
avoidreflectionifpossible
branch
from
6215930
to
9f8202b
Compare
AudricV
added
GUI
AudricV
changed the title
opusforlife2
reviewed
Jan 3, 2023
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Redirion
force-pushed
the
avoidreflectionifpossible
branch
from
c48db08
to
f10d591
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Redirion
added
GUI
Stypox
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
I can confirm the Build.MANUFACTURER on Samsung devices is samsung, see this user's output. Thanks :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Samsung DeX is a feature of Samsung devices. There is no reason to assume it is on other devices. This disables the reflection calls on all devices that aren't manufactured by Samsung.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence