Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI uses last service colours instead of current service used #9632

Open
6 tasks done
Cwpute opened this issue Jan 5, 2023 · 4 comments
Open
6 tasks done

UI uses last service colours instead of current service used #9632

Cwpute opened this issue Jan 5, 2023 · 4 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@Cwpute
Copy link

Cwpute commented Jan 5, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.1

Steps to reproduce the bug

  1. Open the Bandcamp side of the app from the left-side menu
  2. Swith to another app
  3. Open a Youtube link through Newpipe

Expected behavior

The UI should probably bear the colours of the website the media i'm opening is from.

Actual behavior

The UI is now blue instead of red, and the app still thinks i'm using Bandcamp

Screenshots/Screen recordings

Screenshot_20230105-192243

Screenshot_20230105-192253

Logs

No response

Affected Android/Custom ROM version

Android 11

Affected device model

Nokia TA-1157

Additional information

No response

@Cwpute Cwpute added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 5, 2023
@opusforlife2
Copy link
Collaborator

The colour is an indication of which service is currently active within the app for the purpose of searching, and accessing kiosks. Users would be confused if they finished watching/listening to something from an external link, and then tried to search for something, but found that the search results were from a completely different service than what the colour indicated.

@opusforlife2 opusforlife2 added question Not really an issue, but more of a question about how something works and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 5, 2023
@Cwpute
Copy link
Author

Cwpute commented Jan 5, 2023

What if the colour shown on the media page was always that of where the media is taken from, but the active kiosk stays the same so that other pages (like the search page) keep the colour of the active kiosk ?

Or even: what if the active kiosk changes upon viewing/listenning a media page ? This way the colour scheme would still match the active kiosk and the user wouldn't be lost in another kiosk when using the search feuture upon leaving the media page.

@opusforlife2
Copy link
Collaborator

Or even: what if the active kiosk changes upon viewing/listenning a media page ?

It would become quite annoying if the service kept changing with every link you opened.

What if the colour shown wn themedua page was always that of where the media is taken from, but the active kiosk stay the same so that other pages (like the search page) keep the colour of the active kiosk ?

This sounds like a viable option.

@opusforlife2 opusforlife2 reopened this Jan 7, 2023
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface and removed question Not really an issue, but more of a question about how something works labels Jan 7, 2023
@Cwpute
Copy link
Author

Cwpute commented Jan 7, 2023

It would become quite annoying if the service kept changing with every link you opened.

Idk it doesn't happen too much time in my use case. Most of the time i'm switching between 2 kiosks (bandcamp and youtube, for music) when i'm searching for something.
Also to be clear i'm not asking for the kiosk to change every time a media from a different kiosk is played (as in playlists with contents from different kiosks), only to change kiosk when the page for that media is viewed in Newpipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants