Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swipe up and swipe down as a way to get in and out of full screen #9683

Open
6 tasks done
ccuser44 opened this issue Jan 14, 2023 · 9 comments
Open
6 tasks done
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@ccuser44
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

A great feature to improve user experience which is in normal Youtube is being able to swipe in and out of full screen mode

Swiping up on the video should enter full screen
Swiping down on the video if in full screen should go out of full screen.

Why do you want this feature?

This would be a very good way to go in and out of full screen.

Additional information

No response

@ccuser44 ccuser44 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 14, 2023
@SameenAhnaf SameenAhnaf added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Jan 14, 2023
@jcperil
Copy link

jcperil commented Jan 16, 2023

Swiping down on the video if in full screen should go out of full screen.

This would interfere with volume/brightness gesture control.

@ccuser44
Copy link
Author

Swiping down on the video if in full screen should go out of full screen.

This would interfere with volume/brightness gesture control.

Not if its swiped in the middle of the screen

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jan 16, 2023

FYI, Newpipe app can already minimize the player on full screen by swiping down upper interface. So, swiping up from bottom interface could be added for getting out of full screen.

@SameenAhnaf
Copy link
Collaborator

I was talking about getting out of full screen, to be exact.

@mledvd
Copy link

mledvd commented Mar 14, 2023

This would interfere with volume/brightness gesture control.

Not if it's configurable or contained to a certain zone of the screen such as the center. Honestly fullscreen switching makes a lot more sense to me as a default gesture, volume buttons already exist and with gesture control I often get anxious that I could accidentally shred my eardrums. Plus it's the default in the main YT app, it's honestly one of the main things keeping me from switching from Vanced entirely.

@SameenAhnaf
Copy link
Collaborator

YouTube Revanced implemented this way.

Swipe up: Show next and similar videos
Swipe down: Minimise the player
Long press+Swipe up/down on right side: Volume
Long press+Swipe up/down on left side: Brightness

@opusforlife2
Copy link
Collaborator

Oh wow. I really like the idea of having a long-press before swipe for volume and brightness. It makes accidental changes far less likely.

@BrandowLucas

This comment was marked as duplicate.

@KaKi87

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

8 participants
@KaKi87 @opusforlife2 @ccuser44 @mledvd @SameenAhnaf @jcperil @BrandowLucas and others